ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/group/trunk/OOPSE/libmdtools/DumpWriter.cpp
(Generate patch)

Comparing trunk/OOPSE/libmdtools/DumpWriter.cpp (file contents):
Revision 912 by gezelter, Thu Jan 8 18:59:36 2004 UTC vs.
Revision 949 by chuckv, Thu Jan 15 21:57:10 2004 UTC

# Line 3 | Line 3
3   #include <string.h>
4   #include <iostream>
5   #include <fstream>
6 + #include <algorithm>
7 + #include <utility>
8  
9   #ifdef IS_MPI
10   #include <mpi.h>
# Line 26 | Line 28 | DumpWriter::DumpWriter( SimInfo* the_entry_plug ){
28    if(worldRank == 0 ){
29   #endif // is_mpi
30  
31 <    strcpy( outName, entry_plug->sampleName );
31 >    dumpFile.open(entry_plug->sampleName, ios::out | ios::trunc );
32  
33 <    outFile.open(outName, ios::out | ios::trunc );
33 >    if( !dumpFile ){
34  
33 –    if( !outFile ){
34 –
35        sprintf( painCave.errMsg,
36                 "Could not open \"%s\" for dump output.\n",
37 <               outName);
37 >               entry_plug->sampleName);
38        painCave.isFatal = 1;
39        simError();
40      }
41  
42 –    //outFile.setf( ios::scientific );
43 –
42   #ifdef IS_MPI
43    }
44  
45 +  //sort the local atoms by global index
46 +  sortByGlobalIndex();
47 +  
48    sprintf( checkPointMsg,
49             "Sucessfully opened output file for dumping.\n");
50    MPIcheckPoint();
# Line 56 | Line 57 | DumpWriter::~DumpWriter( ){
57    if(worldRank == 0 ){
58   #endif // is_mpi
59  
60 <    outFile.close();
60 >    dumpFile.close();
61  
62   #ifdef IS_MPI
63    }
64   #endif // is_mpi
65   }
66  
67 < void DumpWriter::writeDump( double currentTime ){
67 > #ifdef IS_MPI
68  
69 <  const int BUFFERSIZE = 2000;
70 <  const int MINIBUFFERSIZE = 100;
69 > /**
70 > * A hook function to load balancing
71 > */
72  
73 <  char tempBuffer[BUFFERSIZE];
74 <  char writeLine[BUFFERSIZE];
73 > void DumpWriter::update(){
74 >  sortByGlobalIndex();          
75 > }
76 >  
77 > /**
78 > * Auxiliary sorting function
79 > */
80 >
81 > bool indexSortingCriterion(const pair<int, int>& p1, const pair<int, int>& p2){
82 >  return p1.second < p2.second;
83 > }
84  
85 <  int i;
86 < #ifdef IS_MPI
87 <  int j, which_node, done, which_atom, local_index;
88 <  double atomTransData[6];
89 <  double atomOrientData[7];
79 <  int isDirectional;
80 <  char* atomTypeString;
81 <  char MPIatomTypeString[MINIBUFFERSIZE];
82 <  int me;
83 <  int atomTypeTag;
84 <  int atomIsDirectionalTag;
85 <  int atomTransDataTag;
86 <  int atomOrientDataTag;
87 < #else //is_mpi
88 <  int nAtoms = entry_plug->n_atoms;
89 < #endif //is_mpi
90 <
91 <  double q[4];
92 <  DirectionalAtom* dAtom;
85 > /**
86 > * Sorting the local index by global index
87 > */
88 >
89 > void DumpWriter::sortByGlobalIndex(){
90    Atom** atoms = entry_plug->atoms;
91 <  double pos[3], vel[3];
91 >  
92 >  indexArray.clear();
93 >  
94 >  for(int i = 0; i < mpiSim->getMyNlocal();i++)
95 >    indexArray.push_back(make_pair(i, atoms[i]->getGlobalIndex()));
96 >  
97 >  sort(indexArray.begin(), indexArray.end(), indexSortingCriterion);    
98  
99 <  // write current frame to the eor file
99 >  //for (int i = 0; i < mpiSim->getMyNlocal(); i++) {
100 >  //  printf("node %d has global %d at local %d\n", worldRank, indexArray[i].second, indexArray[i].first);
101 >  //}
102 >    
103 > }
104  
105 <  this->writeFinal( currentTime );
105 > #endif
106  
107 < #ifndef IS_MPI
107 > void DumpWriter::writeDump(double currentTime){
108  
109 <  outFile << nAtoms << "\n";
109 >  ofstream finalOut;
110 >  vector<ofstream*> fileStreams;
111  
112 <  outFile << currentTime << ";\t"
113 <          << entry_plug->Hmat[0][0] << "\t"
114 <          << entry_plug->Hmat[1][0] << "\t"
115 <          << entry_plug->Hmat[2][0] << ";\t"
116 <
117 <          << entry_plug->Hmat[0][1] << "\t"
118 <          << entry_plug->Hmat[1][1] << "\t"
119 <          << entry_plug->Hmat[2][1] << ";\t"
120 <
121 <          << entry_plug->Hmat[0][2] << "\t"
122 <          << entry_plug->Hmat[1][2] << "\t"
123 <          << entry_plug->Hmat[2][2] << ";";
116 <  //write out additional parameters, such as chi and eta
117 <  outFile << entry_plug->the_integrator->getAdditionalParameters();
118 <  outFile << endl;
119 <
120 <  for( i=0; i<nAtoms; i++ ){
121 <
122 <    atoms[i]->getPos(pos);
123 <    atoms[i]->getVel(vel);
124 <
125 <    sprintf( tempBuffer,
126 <             "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
127 <             atoms[i]->getType(),
128 <             pos[0],
129 <             pos[1],
130 <             pos[2],
131 <             vel[0],
132 <             vel[1],
133 <             vel[2]);
134 <    strcpy( writeLine, tempBuffer );
135 <
136 <    if( atoms[i]->isDirectional() ){
137 <
138 <      dAtom = (DirectionalAtom *)atoms[i];
139 <      dAtom->getQ( q );
140 <
141 <      sprintf( tempBuffer,
142 <               "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
143 <               q[0],
144 <               q[1],
145 <               q[2],
146 <               q[3],
147 <               dAtom->getJx(),
148 <               dAtom->getJy(),
149 <               dAtom->getJz());
150 <      strcat( writeLine, tempBuffer );
112 > #ifdef IS_MPI
113 >  printf("Hello from node %d\n", worldRank);
114 >  sortByGlobalIndex();
115 >  if(worldRank == 0 ){
116 >    
117 >    finalOut.open( entry_plug->finalName, ios::out | ios::trunc );
118 >    if( !finalOut ){
119 >      sprintf( painCave.errMsg,
120 >               "Could not open \"%s\" for final dump output.\n",
121 >               entry_plug->finalName );
122 >      painCave.isFatal = 1;
123 >      simError();
124      }
152 –    else
153 –      strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
154 –
155 –    outFile << writeLine;
125    }
126 <  outFile.flush();
126 > #endif // is_mpi
127  
128 < #else // is_mpi
128 >  fileStreams.push_back(&finalOut);
129 >  fileStreams.push_back(&dumpFile);
130  
131 <  // first thing first, suspend fatalities.
162 <  painCave.isEventLoop = 1;
131 >  writeFrame(fileStreams, currentTime);
132  
133 <  int myStatus; // 1 = wakeup & success; 0 = error; -1 = AllDone
134 <  int haveError;
133 > #ifdef IS_MPI
134 >  finalOut.close();
135 > #endif
136 >        
137 > }
138  
139 <  MPI_Status istatus;
168 <  int *AtomToProcMap = mpiSim->getAtomToProcMap();
139 > void DumpWriter::writeFinal(double currentTime){
140  
141 <  // write out header and node 0's coordinates
141 >  ofstream finalOut;
142 >  vector<ofstream*> fileStreams;
143  
144 <  if( worldRank == 0 ){
145 <    outFile << mpiSim->getTotAtoms() << "\n";
144 > #ifdef IS_MPI
145 >  if(worldRank == 0 ){
146  
147 <    outFile << currentTime << ";\t"
176 <            << entry_plug->Hmat[0][0] << "\t"
177 <            << entry_plug->Hmat[1][0] << "\t"
178 <            << entry_plug->Hmat[2][0] << ";\t"
147 >    finalOut.open( entry_plug->finalName, ios::out | ios::trunc );
148  
149 <            << entry_plug->Hmat[0][1] << "\t"
150 <            << entry_plug->Hmat[1][1] << "\t"
151 <            << entry_plug->Hmat[2][1] << ";\t"
149 >    if( !finalOut ){
150 >      sprintf( painCave.errMsg,
151 >               "Could not open \"%s\" for final dump output.\n",
152 >               entry_plug->finalName );
153 >      painCave.isFatal = 1;
154 >      simError();
155 >    }
156  
157 <            << entry_plug->Hmat[0][2] << "\t"
158 <            << entry_plug->Hmat[1][2] << "\t"
186 <            << entry_plug->Hmat[2][2] << ";";
187 <
188 <    outFile << entry_plug->the_integrator->getAdditionalParameters();
189 <    outFile << endl;
190 <    outFile.flush();
191 <    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
192 <      // Get the Node number which has this atom;
193 <
194 <      which_node = AtomToProcMap[i];
195 <
196 <      if (which_node != 0) {
197 <        
198 <        atomTypeTag          = 4*i;
199 <        atomIsDirectionalTag = 4*i + 1;
200 <        atomTransDataTag     = 4*i + 2;
201 <        atomOrientDataTag    = 4*i + 3;
202 <
203 <        MPI_Recv(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, which_node,
204 <                 atomTypeTag, MPI_COMM_WORLD, &istatus);
205 <        
206 <        strncpy(atomTypeString, MPIatomTypeString, MINIBUFFERSIZE);
207 <        
208 <        // Null terminate the atomTypeString just in case:
209 <
210 <        atomTypeString[strlen(atomTypeString) - 1] = '\0';
211 <
212 <        MPI_Recv(&isDirectional, 1, MPI_INT, which_node,
213 <                 atomIsDirectionalTag, MPI_COMM_WORLD, &istatus);
214 <        
215 <        MPI_Recv(atomTransData, 6, MPI_DOUBLE, which_node,
216 <                 atomTransDataTag, MPI_COMM_WORLD, &istatus);
217 <
218 <        if (isDirectional) {
219 <
220 <          MPI_Recv(atomOrientData, 7, MPI_DOUBLE, which_node,
221 <                   atomOrientDataTag, MPI_COMM_WORLD, &istatus);
222 <
223 <        }
224 <
225 <      } else {
226 <        
227 <        haveError = 0;
228 <        which_atom = i;
229 <        local_index=-1;
230 <
231 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
232 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
233 <        }
234 <
235 <        if (local_index != -1) {
236 <
237 <          atomTypeString = atoms[local_index]->getType();
238 <
239 <          atoms[local_index]->getPos(pos);
240 <          atoms[local_index]->getVel(vel);
241 <
242 <          atomTransData[0] = pos[0];
243 <          atomTransData[1] = pos[1];
244 <          atomTransData[2] = pos[2];
245 <
246 <          atomTransData[3] = vel[0];
247 <          atomTransData[4] = vel[1];
248 <          atomTransData[5] = vel[2];
249 <          
250 <          isDirectional = 0;
251 <
252 <          if( atoms[local_index]->isDirectional() ){
253 <
254 <            isDirectional = 1;
255 <            
256 <            dAtom = (DirectionalAtom *)atoms[local_index];
257 <            dAtom->getQ( q );
258 <            
259 <            atomOrientData[0] = q[0];
260 <            atomOrientData[1] = q[1];
261 <            atomOrientData[2] = q[2];
262 <            atomOrientData[3] = q[3];
263 <
264 <            atomOrientData[4] = dAtom->getJx();
265 <            atomOrientData[5] = dAtom->getJy();
266 <            atomOrientData[6] = dAtom->getJz();
267 <          }
268 <
269 <        } else {
270 <          sprintf(painCave.errMsg,
271 <                  "Atom %d not found on processor %d\n",
272 <                  i, worldRank );
273 <          haveError= 1;
274 <          simError();
275 <        }
276 <
277 <        if(haveError) DieDieDie();
278 <                              
279 <        // If we've survived to here, format the line:
280 <        
281 <        sprintf( tempBuffer,
282 <                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
283 <                 atomTypeString,
284 <                 atomTransData[0],
285 <                 atomTransData[1],
286 <                 atomTransData[2],
287 <                 atomTransData[3],
288 <                 atomTransData[4],
289 <                 atomTransData[5]);
290 <
291 <        strcpy( writeLine, tempBuffer );
292 <
293 <        if (isDirectional) {
294 <
295 <          sprintf( tempBuffer,
296 <                   "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
297 <                   atomOrientData[0],
298 <                   atomOrientData[1],
299 <                   atomOrientData[2],
300 <                   atomOrientData[3],
301 <                   atomOrientData[4],
302 <                   atomOrientData[5],
303 <                   atomOrientData[6]);
304 <          strcat( writeLine, tempBuffer );
305 <
306 <        } else {
307 <          strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
308 <        }
309 <
310 <        outFile << writeLine;
311 <        outFile.flush();
312 <      }
313 <    }
314 <
315 <    outFile.flush();
316 <    sprintf( checkPointMsg,
317 <             "Sucessfully took a dump.\n");
318 <    MPIcheckPoint();        
319 <    
320 <  } else {
321 <
322 <    // worldRank != 0, so I'm a remote node.  
323 <    
324 <    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
325 <      
326 <      // Am I the node which has this atom?
327 <      
328 <      if (AtomToProcMap[i] == worldRank) {
329 <
330 <        local_index=-1;
331 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
332 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
333 <        }
334 <        if (local_index != -1) {
335 <        
336 <          atomTypeString = atoms[local_index]->getType();
337 <
338 <          atoms[local_index]->getPos(pos);
339 <          atoms[local_index]->getVel(vel);
340 <
341 <          atomTransData[0] = pos[0];
342 <          atomTransData[1] = pos[1];
343 <          atomTransData[2] = pos[2];
344 <
345 <          atomTransData[3] = vel[0];
346 <          atomTransData[4] = vel[1];
347 <          atomTransData[5] = vel[2];
348 <          
349 <          isDirectional = 0;
350 <
351 <          if( atoms[local_index]->isDirectional() ){
352 <
353 <            isDirectional = 1;
354 <            
355 <            dAtom = (DirectionalAtom *)atoms[local_index];
356 <            dAtom->getQ( q );
357 <            
358 <            atomOrientData[0] = q[0];
359 <            atomOrientData[1] = q[1];
360 <            atomOrientData[2] = q[2];
361 <            atomOrientData[3] = q[3];
362 <
363 <            atomOrientData[4] = dAtom->getJx();
364 <            atomOrientData[5] = dAtom->getJy();
365 <            atomOrientData[6] = dAtom->getJz();
366 <          }
367 <
368 <        } else {
369 <          sprintf(painCave.errMsg,
370 <                  "Atom %d not found on processor %d\n",
371 <                  i, worldRank );
372 <          haveError= 1;
373 <          simError();
374 <        }
375 <
376 <        // I've survived this far, so send off the data!
377 <
378 <        atomTypeTag          = 4*i;
379 <        atomIsDirectionalTag = 4*i + 1;
380 <        atomTransDataTag     = 4*i + 2;
381 <        atomOrientDataTag    = 4*i + 3;
382 <
383 <
384 <        strncpy(MPIatomTypeString, atomTypeString, MINIBUFFERSIZE);
385 <
386 <        // null terminate the string before sending (just in case):
387 <        MPIatomTypeString[MINIBUFFERSIZE-1] = '\0';
388 <
389 <        MPI_Send(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, 0,
390 <                 atomTypeTag, MPI_COMM_WORLD);
391 <        
392 <        MPI_Send(&isDirectional, 1, MPI_INT, 0,
393 <                 atomIsDirectionalTag, MPI_COMM_WORLD);
394 <        
395 <        MPI_Send(atomTransData, 6, MPI_DOUBLE, 0,
396 <                 atomTransDataTag, MPI_COMM_WORLD);
397 <
398 <        if (isDirectional) {
399 <
400 <          MPI_Send(atomOrientData, 7, MPI_DOUBLE, 0,
401 <                   atomOrientDataTag, MPI_COMM_WORLD);
402 <          
403 <        }
404 <      
405 <      }
406 <    }
407 <
408 <    sprintf( checkPointMsg,
409 <             "Sucessfully took a dump.\n");
410 <    MPIcheckPoint();        
411 <    
412 <  }
157 >  }
158 > #endif // is_mpi
159    
160 <  painCave.isEventLoop = 0;
160 >  fileStreams.push_back(&finalOut);  
161 >  writeFrame(fileStreams, currentTime);
162  
163 < #endif // is_mpi
163 > #ifdef IS_MPI
164 >  finalOut.close();
165 > #endif
166 >  
167   }
168  
169 < void DumpWriter::writeFinal(double finalTime){
169 > void DumpWriter::writeFrame( vector<ofstream*>& outFile, double currentTime ){
170  
421 –  char finalName[500];
422 –  ofstream finalOut;
423 –
171    const int BUFFERSIZE = 2000;
172    const int MINIBUFFERSIZE = 100;
173 <  char tempBuffer[BUFFERSIZE];
173 >
174 >  char tempBuffer[BUFFERSIZE];  
175    char writeLine[BUFFERSIZE];
176  
177 <  double q[4];
178 <  DirectionalAtom* dAtom;
431 <  Atom** atoms = entry_plug->atoms;
432 <  int i;
177 >  int i, k;
178 >
179   #ifdef IS_MPI
180 <  int j, which_node, done, which_atom, local_index;
181 <  double atomTransData[6];
182 <  double atomOrientData[7];
180 >  
181 >  /*********************************************************************
182 >   * Documentation?  You want DOCUMENTATION?
183 >   *
184 >   * Why all the potatoes below?  
185 >   *
186 >   * To make a long story short, the original version of DumpWriter
187 >   * worked in the most inefficient way possible.  Node 0 would
188 >   * poke each of the node for an individual atom's formatted data
189 >   * as node 0 worked its way down the global index. This was particularly
190 >   * inefficient since the method blocked all processors at every atom
191 >   * (and did it twice!).
192 >   *
193 >   * An intermediate version of DumpWriter could be described from Node
194 >   * zero's perspective as follows:
195 >   *
196 >   *  1) Have 100 of your friends stand in a circle.
197 >   *  2) When you say go, have all of them start tossing potatoes at
198 >   *     you (one at a time).
199 >   *  3) Catch the potatoes.
200 >   *
201 >   * It was an improvement, but MPI has buffers and caches that could
202 >   * best be described in this analogy as "potato nets", so there's no
203 >   * need to block the processors atom-by-atom.
204 >   *
205 >   * This new and improved DumpWriter works in an even more efficient
206 >   * way:
207 >   *
208 >   *  1) Have 100 of your friend stand in a circle.
209 >   *  2) When you say go, have them start tossing 5-pound bags of
210 >   *     potatoes at you.
211 >   *  3) Once you've caught a friend's bag of potatoes,
212 >   *     toss them a spud to let them know they can toss another bag.
213 >   *
214 >   * How's THAT for documentation?
215 >   *
216 >   *********************************************************************/
217 >
218 >  int *potatoes;
219 >  int myPotato;
220 >
221 >  int nProc;
222 >  int j, which_node, done, which_atom, local_index, currentIndex;
223 >  double atomData6[6];
224 >  double atomData13[13];
225    int isDirectional;
226    char* atomTypeString;
227    char MPIatomTypeString[MINIBUFFERSIZE];
228 <  int atomTypeTag;
441 <  int atomIsDirectionalTag;
442 <  int atomTransDataTag;
443 <  int atomOrientDataTag;
228 >
229   #else //is_mpi
230    int nAtoms = entry_plug->n_atoms;
231   #endif //is_mpi
232  
233 +  double q[4];
234 +  DirectionalAtom* dAtom;
235 +  Atom** atoms = entry_plug->atoms;
236    double pos[3], vel[3];
237  
450 – #ifdef IS_MPI
451 –  if(worldRank == 0 ){
452 – #endif // is_mpi
453 –
454 –    strcpy( finalName, entry_plug->finalName );
455 –
456 –    finalOut.open( finalName, ios::out | ios::trunc );
457 –    if( !finalOut ){
458 –      sprintf( painCave.errMsg,
459 –               "Could not open \"%s\" for final dump output.\n",
460 –               finalName );
461 –      painCave.isFatal = 1;
462 –      simError();
463 –    }
464 –
465 –    // finalOut.setf( ios::scientific );
466 –
467 – #ifdef IS_MPI
468 –  }
469 –
470 –  sprintf(checkPointMsg,"Opened file for final configuration\n");
471 –  MPIcheckPoint();
472 –
473 – #endif //is_mpi
474 –
475 –
238   #ifndef IS_MPI
239 +  
240 +  for(k = 0; k < outFile.size(); k++){
241 +    *outFile[k] << nAtoms << "\n";
242  
243 <  finalOut << nAtoms << "\n";
243 >    *outFile[k] << currentTime << ";\t"
244 >               << entry_plug->Hmat[0][0] << "\t"
245 >                     << entry_plug->Hmat[1][0] << "\t"
246 >                     << entry_plug->Hmat[2][0] << ";\t"
247 >              
248 >               << entry_plug->Hmat[0][1] << "\t"
249 >                     << entry_plug->Hmat[1][1] << "\t"
250 >                     << entry_plug->Hmat[2][1] << ";\t"
251  
252 <  finalOut << finalTime << ";\t"
253 <           << entry_plug->Hmat[0][0] << "\t"
254 <           << entry_plug->Hmat[1][0] << "\t"
483 <           << entry_plug->Hmat[2][0] << ";\t"
252 >                     << entry_plug->Hmat[0][2] << "\t"
253 >                     << entry_plug->Hmat[1][2] << "\t"
254 >                     << entry_plug->Hmat[2][2] << ";";
255  
256 <           << entry_plug->Hmat[0][1] << "\t"
257 <           << entry_plug->Hmat[1][1] << "\t"
258 <           << entry_plug->Hmat[2][1] << ";\t"
259 <
489 <           << entry_plug->Hmat[0][2] << "\t"
490 <           << entry_plug->Hmat[1][2] << "\t"
491 <           << entry_plug->Hmat[2][2] << ";";
492 <
493 <  //write out additional parameters, such as chi and eta
494 <  finalOut << entry_plug->the_integrator->getAdditionalParameters();
495 <  finalOut << endl;
496 <
256 >    //write out additional parameters, such as chi and eta
257 >    *outFile[k] << entry_plug->the_integrator->getAdditionalParameters() << endl;
258 >  }
259 >  
260    for( i=0; i<nAtoms; i++ ){
261  
262      atoms[i]->getPos(pos);
# Line 529 | Line 292 | void DumpWriter::writeFinal(double finalTime){
292      else
293        strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
294  
295 <    finalOut << writeLine;
295 >    for(k = 0; k < outFile.size(); k++)
296 >      *outFile[k] << writeLine;
297    }
534 –  finalOut.flush();
535 –  finalOut.close();
298  
299   #else // is_mpi
300  
301 <  // first thing first, suspend fatalities.
302 <  painCave.isEventLoop = 1;
301 >  /* code to find maximum tag value */
302 >  
303 >  int *tagub, flag, MAXTAG;
304 >  MPI_Attr_get(MPI_COMM_WORLD, MPI_TAG_UB, &tagub, &flag);
305 >  if (flag) {
306 >    MAXTAG = *tagub;
307 >  } else {
308 >    MAXTAG = 32767;
309 >  }  
310  
542 –  int myStatus; // 1 = wakeup & success; 0 = error; -1 = AllDone
311    int haveError;
312  
313    MPI_Status istatus;
# Line 548 | Line 316 | void DumpWriter::writeFinal(double finalTime){
316    // write out header and node 0's coordinates
317  
318    if( worldRank == 0 ){
551 –    finalOut << mpiSim->getTotAtoms() << "\n";
319  
320 <    finalOut << finalTime << ";\t"
554 <            << entry_plug->Hmat[0][0] << "\t"
555 <            << entry_plug->Hmat[1][0] << "\t"
556 <            << entry_plug->Hmat[2][0] << ";\t"
320 >    // Node 0 needs a list of the magic potatoes for each processor;
321  
322 <            << entry_plug->Hmat[0][1] << "\t"
323 <            << entry_plug->Hmat[1][1] << "\t"
560 <            << entry_plug->Hmat[2][1] << ";\t"
322 >    nProc = mpiSim->getNumberProcessors();
323 >    potatoes = new int[nProc];
324  
325 <            << entry_plug->Hmat[0][2] << "\t"
326 <            << entry_plug->Hmat[1][2] << "\t"
327 <            << entry_plug->Hmat[2][2] << ";";
325 >    //write out the comment lines
326 >    for (i = 0; i < nProc; i++)
327 >      potatoes[i] = 0;
328 >    
329 >      for(k = 0; k < outFile.size(); k++){
330 >        *outFile[k] << mpiSim->getTotAtoms() << "\n";
331  
332 <    finalOut << entry_plug->the_integrator->getAdditionalParameters();
333 <    finalOut << endl;
334 <    finalOut.flush();
332 >        *outFile[k] << currentTime << ";\t"
333 >                         << entry_plug->Hmat[0][0] << "\t"
334 >                         << entry_plug->Hmat[1][0] << "\t"
335 >                         << entry_plug->Hmat[2][0] << ";\t"
336 >
337 >                         << entry_plug->Hmat[0][1] << "\t"
338 >                         << entry_plug->Hmat[1][1] << "\t"
339 >                         << entry_plug->Hmat[2][1] << ";\t"
340 >
341 >                         << entry_plug->Hmat[0][2] << "\t"
342 >                         << entry_plug->Hmat[1][2] << "\t"
343 >                         << entry_plug->Hmat[2][2] << ";";
344 >  
345 >        *outFile[k] << entry_plug->the_integrator->getAdditionalParameters() << endl;
346 >    }
347 >
348 >    currentIndex = 0;
349 >
350      for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
351 +      
352        // Get the Node number which has this atom;
353 <
353 >      
354        which_node = AtomToProcMap[i];
355 <
355 >      
356        if (which_node != 0) {
575 –        
576 –        atomTypeTag          = 4*i;
577 –        atomIsDirectionalTag = 4*i + 1;
578 –        atomTransDataTag     = 4*i + 2;
579 –        atomOrientDataTag    = 4*i + 3;
357  
358 +        if (potatoes[which_node] + 3 >= MAXTAG) {
359 +          // The potato was going to exceed the maximum value,
360 +          // so wrap this processor potato back to 0:        
361 +
362 +          potatoes[which_node] = 0;          
363 +          MPI_Send(0, 1, MPI_INT, which_node, 0, MPI_COMM_WORLD);
364 +          
365 +        }
366 +
367 +        myPotato = potatoes[which_node];        
368 +        
369          MPI_Recv(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, which_node,
370 <                 atomTypeTag, MPI_COMM_WORLD, &istatus);
370 >                 myPotato, MPI_COMM_WORLD, &istatus);
371          
372 <        strncpy(atomTypeString, MPIatomTypeString, MINIBUFFERSIZE);
372 >        atomTypeString = MPIatomTypeString;
373 >        
374 >        myPotato++;
375  
376          MPI_Recv(&isDirectional, 1, MPI_INT, which_node,
377 <                 atomIsDirectionalTag, MPI_COMM_WORLD, &istatus);
378 <        
379 <        MPI_Recv(atomTransData, 6, MPI_DOUBLE, which_node,
590 <                 atomTransDataTag, MPI_COMM_WORLD, &istatus);
377 >                 myPotato, MPI_COMM_WORLD, &istatus);
378 >              
379 >        myPotato++;
380  
381 <        if (isDirectional) {
382 <
383 <          MPI_Recv(atomOrientData, 7, MPI_DOUBLE, which_node,
384 <                   atomOrientDataTag, MPI_COMM_WORLD, &istatus);
385 <
381 >        if (isDirectional) {          
382 >          MPI_Recv(atomData13, 13, MPI_DOUBLE, which_node,
383 >                   myPotato, MPI_COMM_WORLD, &istatus);
384 >        } else {
385 >          MPI_Recv(atomData6, 6, MPI_DOUBLE, which_node,
386 >                   myPotato, MPI_COMM_WORLD, &istatus);          
387          }
388 +        
389 +        myPotato++;
390 +        potatoes[which_node] = myPotato;
391  
392        } else {
393          
394 <        haveError = 0;
394 >        haveError = 0;
395          which_atom = i;
396 <        local_index=-1;
396 >        
397 >        //local_index = -1;
398  
399 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
400 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
401 <        }
402 <
403 <        if (local_index != -1) {
404 <
405 <          atomTypeString = atoms[local_index]->getType();
406 <
399 >        //for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
400 >        //  if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
401 >        //}
402 >        
403 >        //if (local_index != -1) {
404 >          
405 >          local_index = indexArray[currentIndex].first;        
406 >          
407 >          if (which_atom == indexArray[currentIndex].second) {
408 >            
409 >            atomTypeString = atoms[local_index]->getType();
410 >            
411            atoms[local_index]->getPos(pos);
412 <          atoms[local_index]->getVel(vel);
412 >          atoms[local_index]->getVel(vel);          
413 >          
414 >          atomData6[0] = pos[0];
415 >          atomData6[1] = pos[1];
416 >          atomData6[2] = pos[2];
417  
418 <          atomTransData[0] = pos[0];
419 <          atomTransData[1] = pos[1];
420 <          atomTransData[2] = pos[2];
619 <
620 <          atomTransData[3] = vel[0];
621 <          atomTransData[4] = vel[1];
622 <          atomTransData[5] = vel[2];
418 >          atomData6[3] = vel[0];
419 >          atomData6[4] = vel[1];
420 >          atomData6[5] = vel[2];
421            
422            isDirectional = 0;
423  
# Line 629 | Line 427 | void DumpWriter::writeFinal(double finalTime){
427              
428              dAtom = (DirectionalAtom *)atoms[local_index];
429              dAtom->getQ( q );
632 –            
633 –            atomOrientData[0] = q[0];
634 –            atomOrientData[1] = q[1];
635 –            atomOrientData[2] = q[2];
636 –            atomOrientData[3] = q[3];
430  
431 <            atomOrientData[4] = dAtom->getJx();
432 <            atomOrientData[5] = dAtom->getJy();
433 <            atomOrientData[6] = dAtom->getJz();
431 >            for (int j = 0; j < 6 ; j++)
432 >              atomData13[j] = atomData6[j];            
433 >            
434 >            atomData13[6] = q[0];
435 >            atomData13[7] = q[1];
436 >            atomData13[8] = q[2];
437 >            atomData13[9] = q[3];
438 >            
439 >            atomData13[10] = dAtom->getJx();
440 >            atomData13[11] = dAtom->getJy();
441 >            atomData13[12] = dAtom->getJz();
442            }
443 <
443 >          
444          } else {
445            sprintf(painCave.errMsg,
446 <                  "Atom %d not found on processor %d\n",
447 <                  i, worldRank );
446 >                  "Atom %d not found on processor %d, currentIndex = %d, local_index = %d\n",
447 >                  which_atom, worldRank, currentIndex, local_index );
448            haveError= 1;
449            simError();
450          }
650 –
651 –        if(haveError) DieDieDie();
652 –                              
653 –        // If we've survived to here, format the line:
451          
452 <        sprintf( tempBuffer,
453 <                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
454 <                 atomTypeString,
658 <                 atomTransData[0],
659 <                 atomTransData[1],
660 <                 atomTransData[2],
661 <                 atomTransData[3],
662 <                 atomTransData[4],
663 <                 atomTransData[5]);
664 <
665 <        strcpy( writeLine, tempBuffer );
666 <
667 <        if (isDirectional) {
668 <
669 <          sprintf( tempBuffer,
670 <                   "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
671 <                   atomOrientData[0],
672 <                   atomOrientData[1],
673 <                   atomOrientData[2],
674 <                   atomOrientData[3],
675 <                   atomOrientData[4],
676 <                   atomOrientData[5],
677 <                   atomOrientData[6]);
678 <          strcat( writeLine, tempBuffer );
679 <
680 <        } else {
681 <          strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
682 <        }
683 <
684 <        finalOut << writeLine;
685 <        finalOut.flush();
452 >        if(haveError) DieDieDie();
453 >        
454 >        currentIndex++;
455        }
456 +      // If we've survived to here, format the line:
457 +      
458 +      if (!isDirectional) {
459 +        
460 +        sprintf( writeLine,
461 +                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
462 +                 atomTypeString,
463 +                 atomData6[0],
464 +                 atomData6[1],
465 +                 atomData6[2],
466 +                 atomData6[3],
467 +                 atomData6[4],
468 +                 atomData6[5]);
469 +        
470 +        strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
471 +        
472 +      } else {
473 +        
474 +        sprintf( writeLine,
475 +                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
476 +                 atomTypeString,
477 +                 atomData13[0],
478 +                 atomData13[1],
479 +                 atomData13[2],
480 +                 atomData13[3],
481 +                 atomData13[4],
482 +                 atomData13[5],
483 +                 atomData13[6],
484 +                 atomData13[7],
485 +                 atomData13[8],
486 +                 atomData13[9],
487 +                 atomData13[10],
488 +                 atomData13[11],
489 +                 atomData13[12]);
490 +        
491 +      }
492 +      
493 +      for(k = 0; k < outFile.size(); k++)
494 +        *outFile[k] << writeLine;
495      }
496 <
497 <    finalOut.flush();
496 >    
497 >    for(k = 0; k < outFile.size(); k++)
498 >      outFile[k]->flush();
499 >    
500      sprintf( checkPointMsg,
501               "Sucessfully took a dump.\n");
502 +    
503      MPIcheckPoint();        
504      
505 +    delete[] potatoes;
506 +    
507    } else {
508  
509      // worldRank != 0, so I'm a remote node.  
510 +
511 +    // Set my magic potato to 0:
512 +
513 +    myPotato = 0;
514 +    currentIndex = 0;
515      
516      for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
517        
# Line 701 | Line 519 | void DumpWriter::writeFinal(double finalTime){
519        
520        if (AtomToProcMap[i] == worldRank) {
521  
522 <        local_index=-1;
523 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
524 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
522 >        if (myPotato + 3 >= MAXTAG) {
523 >          
524 >          // The potato was going to exceed the maximum value,
525 >          // so wrap this processor potato back to 0 (and block until
526 >          // node 0 says we can go:
527 >          
528 >          MPI_Recv(&myPotato, 1, MPI_INT, 0, 0, MPI_COMM_WORLD, &istatus);
529 >          
530          }
531 <        if (local_index != -1) {
531 >        which_atom = i;
532 >
533 >        //local_index = -1;
534 >
535 >        //for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
536 >        // if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
537 >        //}
538 >        
539 >        //if (local_index != -1) {
540 >
541 >        local_index = indexArray[currentIndex].first;        
542 >                
543 >        if (which_atom == indexArray[currentIndex].second) {
544          
545            atomTypeString = atoms[local_index]->getType();
546 <
546 >          
547            atoms[local_index]->getPos(pos);
548            atoms[local_index]->getVel(vel);
549 +          
550 +          atomData6[0] = pos[0];
551 +          atomData6[1] = pos[1];
552 +          atomData6[2] = pos[2];
553  
554 <          atomTransData[0] = pos[0];
555 <          atomTransData[1] = pos[1];
556 <          atomTransData[2] = pos[2];
718 <
719 <          atomTransData[3] = vel[0];
720 <          atomTransData[4] = vel[1];
721 <          atomTransData[5] = vel[2];
554 >          atomData6[3] = vel[0];
555 >          atomData6[4] = vel[1];
556 >          atomData6[5] = vel[2];
557            
558            isDirectional = 0;
559  
# Line 729 | Line 564 | void DumpWriter::writeFinal(double finalTime){
564              dAtom = (DirectionalAtom *)atoms[local_index];
565              dAtom->getQ( q );
566              
567 <            atomOrientData[0] = q[0];
568 <            atomOrientData[1] = q[1];
569 <            atomOrientData[2] = q[2];
570 <            atomOrientData[3] = q[3];
571 <
572 <            atomOrientData[4] = dAtom->getJx();
573 <            atomOrientData[5] = dAtom->getJy();
574 <            atomOrientData[6] = dAtom->getJz();
567 >            for (int j = 0; j < 6 ; j++)
568 >              atomData13[j] = atomData6[j];
569 >            
570 >            atomData13[6] = q[0];
571 >            atomData13[7] = q[1];
572 >            atomData13[8] = q[2];
573 >            atomData13[9] = q[3];
574 >  
575 >            atomData13[10] = dAtom->getJx();
576 >            atomData13[11] = dAtom->getJy();
577 >            atomData13[12] = dAtom->getJz();
578            }
579  
580          } else {
581            sprintf(painCave.errMsg,
582 <                  "Atom %d not found on processor %d\n",
583 <                  i, worldRank );
582 >                  "Atom %d not found on processor %d, currentIndex = %d, local_index = %d\n",
583 >                  which_atom, worldRank, currentIndex, local_index );
584            haveError= 1;
585            simError();
586          }
587 <
750 <        // I've survived this far, so send off the data!
751 <
752 <        atomTypeTag          = 4*i;
753 <        atomIsDirectionalTag = 4*i + 1;
754 <        atomTransDataTag     = 4*i + 2;
755 <        atomOrientDataTag    = 4*i + 3;
756 <
587 >        
588          strncpy(MPIatomTypeString, atomTypeString, MINIBUFFERSIZE);
589  
590 +        // null terminate the string before sending (just in case):
591 +        MPIatomTypeString[MINIBUFFERSIZE-1] = '\0';
592 +
593          MPI_Send(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, 0,
594 <                 atomTypeTag, MPI_COMM_WORLD);
594 >                             myPotato, MPI_COMM_WORLD);
595          
596 +        myPotato++;
597 +
598          MPI_Send(&isDirectional, 1, MPI_INT, 0,
599 <                 atomIsDirectionalTag, MPI_COMM_WORLD);
599 >                             myPotato, MPI_COMM_WORLD);
600          
601 <        MPI_Send(atomTransData, 6, MPI_DOUBLE, 0,
602 <                 atomTransDataTag, MPI_COMM_WORLD);
767 <
601 >        myPotato++;
602 >        
603          if (isDirectional) {
604  
605 <          MPI_Send(atomOrientData, 7, MPI_DOUBLE, 0,
606 <                   atomOrientDataTag, MPI_COMM_WORLD);
605 >          MPI_Send(atomData13, 13, MPI_DOUBLE, 0,
606 >                   myPotato, MPI_COMM_WORLD);
607            
608 +        } else {
609 +
610 +          MPI_Send(atomData6, 6, MPI_DOUBLE, 0,
611 +                   myPotato, MPI_COMM_WORLD);
612          }
613 <      
613 >
614 >        myPotato++;  
615 >        currentIndex++;    
616        }
617      }
618  
619      sprintf( checkPointMsg,
620 <             "Sucessfully wrote final file.\n");
620 >             "Sucessfully took a dump.\n");
621      MPIcheckPoint();        
622      
623 <  }
623 >  }
624    
784 –  painCave.isEventLoop = 0;
785 –
786 –  if( worldRank == 0 ) finalOut.close();
625   #endif // is_mpi
626   }
627  
790 –
791 –
628   #ifdef IS_MPI
629  
630   // a couple of functions to let us escape the write loop

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines