ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/OpenMD/trunk/src/math/ConvexHull.cpp
(Generate patch)

Comparing trunk/src/math/ConvexHull.cpp (file contents):
Revision 1377 by gezelter, Wed Oct 21 02:49:43 2009 UTC vs.
Revision 1969 by gezelter, Wed Feb 26 14:14:50 2014 UTC

# Line 1 | Line 1
1 < /* Copyright (c) 2008, 2009 The University of Notre Dame. All Rights Reserved.
1 > /* Copyright (c) 2010 The University of Notre Dame. All Rights Reserved.
2   *
3   * The University of Notre Dame grants you ("Licensee") a
4   * non-exclusive, royalty free, license to use, modify and
5   * redistribute this software in source and binary code form, provided
6   * that the following conditions are met:
7   *
8 < * 1. Acknowledgement of the program authors must be made in any
9 < *    publication of scientific results based in part on use of the
10 < *    program.  An acceptable form of acknowledgement is citation of
11 < *    the article in which the program was described (Matthew
12 < *    A. Meineke, Charles F. Vardeman II, Teng Lin, Christopher
13 < *    J. Fennell and J. Daniel Gezelter, "OOPSE: An Object-Oriented
14 < *    Parallel Simulation Engine for Molecular Dynamics,"
15 < *    J. Comput. Chem. 26, pp. 252-271 (2005))
16 < *
17 < * 2. Redistributions of source code must retain the above copyright
8 > * 1. Redistributions of source code must retain the above copyright
9   *    notice, this list of conditions and the following disclaimer.
10   *
11 < * 3. Redistributions in binary form must reproduce the above copyright
11 > * 2. Redistributions in binary form must reproduce the above copyright
12   *    notice, this list of conditions and the following disclaimer in the
13   *    documentation and/or other materials provided with the
14   *    distribution.
# Line 37 | Line 28
28   * University of Notre Dame has been advised of the possibility of
29   * such damages.
30   *
31 + * SUPPORT OPEN SCIENCE!  If you use OpenMD or its source code in your
32 + * research, please cite the appropriate papers when you publish your
33 + * work.  Good starting points are:
34 + *                                                                      
35 + * [1] Meineke, et al., J. Comp. Chem. 26, 252-271 (2005).            
36 + * [2] Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006).          
37 + * [3] Sun, Lin & Gezelter, J. Chem. Phys. 128, 234107 (2008).          
38 + * [4] Kuang & Gezelter,  J. Chem. Phys. 133, 164101 (2010).
39 + * [5] Vardeman, Stocker & Gezelter, J. Chem. Theory Comput. 7, 834 (2011).
40   *
41   *  ConvexHull.cpp
42   *
43 < *  Purpose: To calculate convexhull, hull volume libqhull.
44 < *
45 < *  Created by Charles F. Vardeman II on 11 Dec 2006.
46 < *  @author  Charles F. Vardeman II
47 < *  @version $Id: ConvexHull.cpp,v 1.18 2009-10-21 02:49:43 gezelter Exp $
48 < *
43 > *  Purpose: To calculate a convex hull.
44   */
45  
46 + #ifdef IS_MPI
47 + #include <mpi.h>
48 + #endif
49 +
50   /* Standard includes independent of library */
51  
52   #include <iostream>
# Line 58 | Line 57
57   #include "math/ConvexHull.hpp"
58   #include "utils/simError.h"
59  
60 < #ifdef IS_MPI
62 < #include <mpi.h>
63 < #endif
60 > #include "math/qhull.hpp"
61  
65 using namespace oopse;
66
62   #ifdef HAVE_QHULL
63 < extern "C"
64 < {
70 < #include <qhull/qhull.h>
71 < #include <qhull/mem.h>
72 < #include <qhull/qset.h>
73 < #include <qhull/geom.h>
74 < #include <qhull/merge.h>
75 < #include <qhull/poly.h>
76 < #include <qhull/io.h>
77 < #include <qhull/stat.h>
78 < }
63 > using namespace OpenMD;
64 > using namespace std;
65  
66 < /* Old options Qt Qu Qg QG0 FA */
81 < /* More old opts Qc Qi Pp*/
82 <
83 < ConvexHull::ConvexHull() : Hull(), dim_(3), options_("qhull Qt Pp") {
66 > ConvexHull::ConvexHull() : Hull(), dim_(3), options_("qhull FA Qt Pp") {
67   }
68  
69 < void ConvexHull::computeHull(std::vector<StuntDouble*> bodydoubles) {
70 <
69 > void ConvexHull::computeHull(vector<StuntDouble*> bodydoubles) {
70 >  
71    int numpoints = bodydoubles.size();
72 <
72 >  
73    Triangles_.clear();
74    
75    vertexT *vertex, **vertexp;
76    facetT *facet;
77    setT *vertices;
78    int curlong, totlong;
96  
97  std::vector<double> ptArray(numpoints*3);
98  std::vector<bool> isSurfaceID(numpoints);
79  
80 +  vector<double> ptArray(numpoints*dim_);
81 +
82    // Copy the positon vector into a points vector for qhull.
83 <  std::vector<StuntDouble*>::iterator SD;
83 >  vector<StuntDouble*>::iterator SD;
84    int i = 0;
85 +
86    for (SD =bodydoubles.begin(); SD != bodydoubles.end(); ++SD){
87      Vector3d pos = (*SD)->getPos();      
88      ptArray[dim_ * i] = pos.x();
# Line 108 | Line 91 | void ConvexHull::computeHull(std::vector<StuntDouble*>
91      i++;
92    }
93    
94 +  /* Clean up memory from previous convex hull calculations */
95    boolT ismalloc = False;
112  /* Clean up memory from previous convex hull calculations*/
96    
97 +  /* compute the hull for our local points (or all the points for single
98 +     processor versions) */
99    if (qh_new_qhull(dim_, numpoints, &ptArray[0], ismalloc,
100                     const_cast<char *>(options_.c_str()), NULL, stderr)) {
101 <
101 >    
102      sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute convex hull");
103      painCave.isFatal = 1;
104      simError();
# Line 124 | Line 109 | void ConvexHull::computeHull(std::vector<StuntDouble*>
109   #ifdef IS_MPI
110    //If we are doing the mpi version, set up some vectors for data communication
111    
112 <  int nproc = MPI::COMM_WORLD.Get_size();
113 <  int myrank = MPI::COMM_WORLD.Get_rank();
112 >  int nproc;
113 >  int myrank;
114 >  
115 >  MPI_Comm_size( MPI_COMM_WORLD, &nproc);
116 >  MPI_Comm_rank( MPI_COMM_WORLD, &myrank);
117 >
118    int localHullSites = 0;
130  int* hullSitesOnProc = new int[nproc];
131  int* coordsOnProc = new int[nproc];
132  int* displacements = new int[nproc];
133  int* vectorDisplacements = new int[nproc];
119  
120 <  std::vector<double> coords;
121 <  std::vector<double> vels;
122 <  std::vector<int> objectIDs;
123 <  std::vector<double> masses;
120 >  vector<int> hullSitesOnProc(nproc, 0);
121 >  vector<int> coordsOnProc(nproc, 0);
122 >  vector<int> displacements(nproc, 0);
123 >  vector<int> vectorDisplacements(nproc, 0);
124  
125 +  vector<double> coords;
126 +  vector<double> vels;
127 +  vector<int> indexMap;
128 +  vector<double> masses;
129 +
130    FORALLvertices{
131      localHullSites++;
132      
133      int idx = qh_pointid(vertex->point);
134 +
135 +    indexMap.push_back(idx);
136 +
137      coords.push_back(ptArray[dim_  * idx]);
138      coords.push_back(ptArray[dim_  * idx + 1]);
139      coords.push_back(ptArray[dim_  * idx + 2]);
# Line 155 | Line 148 | void ConvexHull::computeHull(std::vector<StuntDouble*>
148      masses.push_back(sd->getMass());
149    }
150  
151 +  MPI_Allgather(&localHullSites, 1, MPI_INT, &hullSitesOnProc[0],
152 +                1, MPI_INT, MPI_COMM_WORLD);
153  
159
160  MPI::COMM_WORLD.Allgather(&localHullSites, 1, MPI::INT, &hullSitesOnProc[0],
161                            1, MPI::INT);
162
154    int globalHullSites = 0;
155    for (int iproc = 0; iproc < nproc; iproc++){
156      globalHullSites += hullSitesOnProc[iproc];
# Line 174 | Line 165 | void ConvexHull::computeHull(std::vector<StuntDouble*>
165      vectorDisplacements[iproc] = vectorDisplacements[iproc-1] + coordsOnProc[iproc-1];
166    }
167  
168 <  std::vector<double> globalCoords(dim_ * globalHullSites);
169 <  std::vector<double> globalVels(dim_ * globalHullSites);
170 <  std::vector<double> globalMasses(globalHullSites);
168 >  vector<double> globalCoords(dim_ * globalHullSites);
169 >  vector<double> globalVels(dim_ * globalHullSites);
170 >  vector<double> globalMasses(globalHullSites);
171  
172    int count = coordsOnProc[myrank];
173    
174 <  MPI::COMM_WORLD.Allgatherv(&coords[0], count, MPI::DOUBLE, &globalCoords[0],
175 <                             &coordsOnProc[0], &vectorDisplacements[0],
176 <                             MPI::DOUBLE);
177 <
178 <  MPI::COMM_WORLD.Allgatherv(&vels[0], count, MPI::DOUBLE, &globalVels[0],
179 <                             &coordsOnProc[0], &vectorDisplacements[0],
180 <                             MPI::DOUBLE);
181 <
182 <  MPI::COMM_WORLD.Allgatherv(&masses[0], localHullSites, MPI::DOUBLE,
183 <                             &globalMasses[0], &hullSitesOnProc[0],
184 <                             &displacements[0], MPI::DOUBLE);
185 <
174 >  MPI_Allgatherv(&coords[0], count, MPI_DOUBLE, &globalCoords[0],
175 >                 &coordsOnProc[0], &vectorDisplacements[0],
176 >                 MPI_DOUBLE, MPI_COMM_WORLD);
177 >  
178 >  MPI_Allgatherv(&vels[0], count, MPI_DOUBLE, &globalVels[0],
179 >                 &coordsOnProc[0], &vectorDisplacements[0],
180 >                 MPI_DOUBLE, MPI_COMM_WORLD);
181 >  
182 >  MPI_Allgatherv(&masses[0], localHullSites, MPI_DOUBLE,
183 >                 &globalMasses[0], &hullSitesOnProc[0],
184 >                 &displacements[0], MPI_DOUBLE, MPI_COMM_WORLD);
185 >  
186    // Free previous hull
187    qh_freeqhull(!qh_ALL);
188    qh_memfreeshort(&curlong, &totlong);
189 <  if (curlong || totlong)
190 <    std::cerr << "qhull internal warning (main): did not free %d bytes of long memory (%d pieces) "
191 <              << totlong << curlong << std::endl;
189 >  if (curlong || totlong) {
190 >    sprintf(painCave.errMsg, "ConvexHull: qhull internal warning:\n"
191 >            "\tdid not free %d bytes of long memory (%d pieces)",
192 >            totlong, curlong);
193 >    painCave.isFatal = 1;
194 >    simError();
195 >  }
196    
197    if (qh_new_qhull(dim_, globalHullSites, &globalCoords[0], ismalloc,
198                     const_cast<char *>(options_.c_str()), NULL, stderr)){
199      
200 <    sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute global convex hull");
200 >    sprintf(painCave.errMsg,
201 >            "ConvexHull: Qhull failed to compute global convex hull");
202      painCave.isFatal = 1;
203      simError();
204      
205    } //qh_new_qhull
206  
207   #endif
208 +  // commented out below, so comment out here also.
209 +  // intPoint = qh interior_point;
210 +  // RealType calcvol = 0.0;
211 +  
212 +  qh_triangulate ();
213  
214    FORALLfacets {  
215      Triangle face;
216 <
216 >    //Qhull sets the unit normal in facet->normal
217      Vector3d V3dNormal(facet->normal[0], facet->normal[1], facet->normal[2]);
218 <    face.setNormal(V3dNormal);
218 >    face.setUnitNormal(V3dNormal);
219      
220      RealType faceArea = qh_facetarea(facet);
221      face.setArea(faceArea);
# Line 236 | Line 237 | void ConvexHull::computeHull(std::vector<StuntDouble*>
237        p[ver][0] = vertex->point[0];
238        p[ver][1] = vertex->point[1];
239        p[ver][2] = vertex->point[2];
239      
240        Vector3d vel;
241        RealType mass;
242  
# Line 251 | Line 251 | void ConvexHull::computeHull(std::vector<StuntDouble*>
251  
252        int localID = id - displacements[myrank];
253  
254 <      if (localID >= 0 && localID < hullSitesOnProc[myrank])
255 <        face.addVertexSD(bodydoubles[localID]);
256 <      
254 >
255 >      if (localID >= 0 && localID < hullSitesOnProc[myrank]){
256 >        face.addVertexSD(bodydoubles[indexMap[localID]]);
257 >      }else{
258 >        face.addVertexSD(NULL);
259 >      }
260   #else
261        vel = bodydoubles[id]->getVel();
262        mass = bodydoubles[id]->getMass();
263        face.addVertexSD(bodydoubles[id]);      
264 < #endif
262 <        
264 > #endif  
265        faceVel = faceVel + vel;
266        faceMass = faceMass + mass;
267        ver++;      
# Line 267 | Line 269 | void ConvexHull::computeHull(std::vector<StuntDouble*>
269  
270      face.addVertices(p[0], p[1], p[2]);
271      face.setFacetMass(faceMass);
272 <    face.setFacetVelocity(faceVel/3.0);
272 >    face.setFacetVelocity(faceVel / RealType(3.0));
273 >    /*
274 >    RealType comparea = face.computeArea();
275 >    realT calcarea = qh_facetarea (facet);
276 >    Vector3d V3dCompNorm = -face.computeUnitNormal();
277 >    RealType thisOffset = ((0.0-p[0][0])*V3dCompNorm[0] + (0.0-p[0][1])*V3dCompNorm[1] + (0.0-p[0][2])*V3dCompNorm[2]);
278 >    RealType dist = facet->offset + intPoint[0]*V3dNormal[0] + intPoint[1]*V3dNormal[1] + intPoint[2]*V3dNormal[2];
279 >    cout << "facet offset and computed offset: " << facet->offset << "  " << thisOffset <<  endl;
280 >    calcvol +=  -dist*comparea/qh hull_dim;
281 >    */
282      Triangles_.push_back(face);
283      qh_settempfree(&vertices);      
284  
# Line 276 | Line 287 | void ConvexHull::computeHull(std::vector<StuntDouble*>
287    qh_getarea(qh facet_list);
288    volume_ = qh totvol;
289    area_ = qh totarea;
290 <
280 < #ifdef IS_MPI
281 <  delete [] hullSitesOnProc;
282 <  delete [] coordsOnProc;
283 <  delete [] displacements;
284 <  delete [] vectorDisplacements;
285 < #endif
286 <  
290 >    
291    qh_freeqhull(!qh_ALL);
292    qh_memfreeshort(&curlong, &totlong);
293 <  if (curlong || totlong)
294 <    std::cerr << "qhull internal warning (main): did not free %d bytes of long memory (%d pieces) "
295 <              << totlong << curlong << std::endl;    
293 >  if (curlong || totlong) {
294 >    sprintf(painCave.errMsg, "ConvexHull: qhull internal warning:\n"
295 >            "\tdid not free %d bytes of long memory (%d pieces)",
296 >            totlong, curlong);
297 >    painCave.isFatal = 1;
298 >    simError();
299 >  }
300   }
301  
302 < void ConvexHull::printHull(const std::string& geomFileName) {
295 <  FILE *newGeomFile;
302 > void ConvexHull::printHull(const string& geomFileName) {
303    
304 <  //create new .md file based on old .md file
305 <  newGeomFile = fopen(geomFileName.c_str(), "w");
306 <  qh_findgood_all(qh facet_list);
307 <  for (int i = 0; i < qh_PRINTEND; i++)
308 <    qh_printfacets(newGeomFile, qh PRINTout[i], qh facet_list, NULL, !qh_ALL);
309 <  
310 <  fclose(newGeomFile);
304 > #ifdef IS_MPI
305 >  if (worldRank == 0)  {
306 > #endif
307 >    FILE *newGeomFile;
308 >    
309 >    //create new .md file based on old .md file
310 >    newGeomFile = fopen(geomFileName.c_str(), "w");
311 >    qh_findgood_all(qh facet_list);
312 >    for (int i = 0; i < qh_PRINTEND; i++)
313 >      qh_printfacets(newGeomFile, qh PRINTout[i], qh facet_list, NULL, !qh_ALL);
314 >    
315 >    fclose(newGeomFile);
316 > #ifdef IS_MPI
317 >  }
318 > #endif
319   }
320   #endif //QHULL

Comparing trunk/src/math/ConvexHull.cpp (property svn:keywords):
Revision 1377 by gezelter, Wed Oct 21 02:49:43 2009 UTC vs.
Revision 1969 by gezelter, Wed Feb 26 14:14:50 2014 UTC

# Line 0 | Line 1
1 + Author Id Revision Date

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines