ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/OpenMD/trunk/src/math/ConvexHull.cpp
(Generate patch)

Comparing trunk/src/math/ConvexHull.cpp (file contents):
Revision 1371 by chuckv, Mon Oct 19 17:44:18 2009 UTC vs.
Revision 1969 by gezelter, Wed Feb 26 14:14:50 2014 UTC

# Line 1 | Line 1
1 < /* Copyright (c) 2008, 2009 The University of Notre Dame. All Rights Reserved.
1 > /* Copyright (c) 2010 The University of Notre Dame. All Rights Reserved.
2   *
3   * The University of Notre Dame grants you ("Licensee") a
4   * non-exclusive, royalty free, license to use, modify and
5   * redistribute this software in source and binary code form, provided
6   * that the following conditions are met:
7   *
8 < * 1. Acknowledgement of the program authors must be made in any
9 < *    publication of scientific results based in part on use of the
10 < *    program.  An acceptable form of acknowledgement is citation of
11 < *    the article in which the program was described (Matthew
12 < *    A. Meineke, Charles F. Vardeman II, Teng Lin, Christopher
13 < *    J. Fennell and J. Daniel Gezelter, "OOPSE: An Object-Oriented
14 < *    Parallel Simulation Engine for Molecular Dynamics,"
15 < *    J. Comput. Chem. 26, pp. 252-271 (2005))
16 < *
17 < * 2. Redistributions of source code must retain the above copyright
8 > * 1. Redistributions of source code must retain the above copyright
9   *    notice, this list of conditions and the following disclaimer.
10   *
11 < * 3. Redistributions in binary form must reproduce the above copyright
11 > * 2. Redistributions in binary form must reproduce the above copyright
12   *    notice, this list of conditions and the following disclaimer in the
13   *    documentation and/or other materials provided with the
14   *    distribution.
# Line 37 | Line 28
28   * University of Notre Dame has been advised of the possibility of
29   * such damages.
30   *
31 + * SUPPORT OPEN SCIENCE!  If you use OpenMD or its source code in your
32 + * research, please cite the appropriate papers when you publish your
33 + * work.  Good starting points are:
34 + *                                                                      
35 + * [1] Meineke, et al., J. Comp. Chem. 26, 252-271 (2005).            
36 + * [2] Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006).          
37 + * [3] Sun, Lin & Gezelter, J. Chem. Phys. 128, 234107 (2008).          
38 + * [4] Kuang & Gezelter,  J. Chem. Phys. 133, 164101 (2010).
39 + * [5] Vardeman, Stocker & Gezelter, J. Chem. Theory Comput. 7, 834 (2011).
40   *
41   *  ConvexHull.cpp
42   *
43 < *  Purpose: To calculate convexhull, hull volume libqhull.
44 < *
45 < *  Created by Charles F. Vardeman II on 11 Dec 2006.
46 < *  @author  Charles F. Vardeman II
47 < *  @version $Id: ConvexHull.cpp,v 1.15 2009-10-19 17:44:18 chuckv Exp $
48 < *
43 > *  Purpose: To calculate a convex hull.
44   */
45  
46 + #ifdef IS_MPI
47 + #include <mpi.h>
48 + #endif
49 +
50   /* Standard includes independent of library */
51 +
52   #include <iostream>
53   #include <fstream>
54   #include <list>
# Line 57 | Line 57
57   #include "math/ConvexHull.hpp"
58   #include "utils/simError.h"
59  
60 + #include "math/qhull.hpp"
61  
62 < using namespace oopse;
62 > #ifdef HAVE_QHULL
63 > using namespace OpenMD;
64 > using namespace std;
65  
66 < /* CGAL version of convex hull first then QHULL */
67 < #ifdef HAVE_CGAL
65 < //#include <CGAL/Homogeneous.h>
66 < #include <CGAL/basic.h>
67 < //#include <CGAL/Simple_cartesian.h>
68 < #include <CGAL/Cartesian.h>
69 < #include <CGAL/Origin.h>
70 < #include <CGAL/Exact_predicates_exact_constructions_kernel.h>
71 < #include <CGAL/Convex_hull_traits_3.h>
72 < #include <CGAL/convex_hull_3.h>
73 < #include <CGAL/Polyhedron_traits_with_normals_3.h>
74 < #include <CGAL/Polyhedron_3.h>
75 < #include <CGAL/double.h>
76 < #include <CGAL/number_utils.h>
66 > ConvexHull::ConvexHull() : Hull(), dim_(3), options_("qhull FA Qt Pp") {
67 > }
68  
69 + void ConvexHull::computeHull(vector<StuntDouble*> bodydoubles) {
70 +  
71 +  int numpoints = bodydoubles.size();
72 +  
73 +  Triangles_.clear();
74 +  
75 +  vertexT *vertex, **vertexp;
76 +  facetT *facet;
77 +  setT *vertices;
78 +  int curlong, totlong;
79  
80 < //#include <CGAL/Quotient.h>
80 < #include <CGAL/MP_Float.h>
81 < //#include <CGAL/Lazy_exact_nt.h>
80 >  vector<double> ptArray(numpoints*dim_);
81  
82 +  // Copy the positon vector into a points vector for qhull.
83 +  vector<StuntDouble*>::iterator SD;
84 +  int i = 0;
85 +
86 +  for (SD =bodydoubles.begin(); SD != bodydoubles.end(); ++SD){
87 +    Vector3d pos = (*SD)->getPos();      
88 +    ptArray[dim_ * i] = pos.x();
89 +    ptArray[dim_ * i + 1] = pos.y();
90 +    ptArray[dim_ * i + 2] = pos.z();
91 +    i++;
92 +  }
93 +  
94 +  /* Clean up memory from previous convex hull calculations */
95 +  boolT ismalloc = False;
96 +  
97 +  /* compute the hull for our local points (or all the points for single
98 +     processor versions) */
99 +  if (qh_new_qhull(dim_, numpoints, &ptArray[0], ismalloc,
100 +                   const_cast<char *>(options_.c_str()), NULL, stderr)) {
101 +    
102 +    sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute convex hull");
103 +    painCave.isFatal = 1;
104 +    simError();
105 +    
106 +  } //qh_new_qhull
107  
108  
109 < typedef CGAL::MP_Float RT;
110 < //typedef double RT;
111 < //typedef CGAL::Homogeneous<RT>                     K;
112 < typedef CGAL::Exact_predicates_exact_constructions_kernel K;
113 < typedef K::Vector_3                               Vector_3;
114 < //typedef CGAL::Convex_hull_traits_3<K>             Traits;
115 < typedef CGAL::Polyhedron_traits_with_normals_3<K> Traits;
116 < //typedef Traits::Polyhedron_3                      Polyhedron_3;
93 < typedef CGAL::Polyhedron_3<Traits>                     Polyhedron_3;
94 < typedef K::Point_3                                Point_3;
109 > #ifdef IS_MPI
110 >  //If we are doing the mpi version, set up some vectors for data communication
111 >  
112 >  int nproc;
113 >  int myrank;
114 >  
115 >  MPI_Comm_size( MPI_COMM_WORLD, &nproc);
116 >  MPI_Comm_rank( MPI_COMM_WORLD, &myrank);
117  
118 +  int localHullSites = 0;
119  
120 < typedef Polyhedron_3::HalfedgeDS             HalfedgeDS;
121 < typedef Polyhedron_3::Facet_iterator                   Facet_iterator;
122 < typedef Polyhedron_3::Halfedge_around_facet_circulator Halfedge_facet_circulator;
123 < typedef Polyhedron_3::Halfedge_handle Halfedge_handle;
101 < typedef Polyhedron_3::Facet_iterator Facet_iterator;
102 < typedef Polyhedron_3::Plane_iterator Plane_iterator;
103 < typedef Polyhedron_3::Vertex_iterator Vertex_iterator;
104 < typedef Polyhedron_3::Vertex_handle Vertex_handle;
105 < typedef Polyhedron_3::Point_iterator Point_iterator;
106 <
120 >  vector<int> hullSitesOnProc(nproc, 0);
121 >  vector<int> coordsOnProc(nproc, 0);
122 >  vector<int> displacements(nproc, 0);
123 >  vector<int> vectorDisplacements(nproc, 0);
124  
125 +  vector<double> coords;
126 +  vector<double> vels;
127 +  vector<int> indexMap;
128 +  vector<double> masses;
129  
130 < class Enriched_Point_3 : public K::Point_3{
131 < public:
132 <  Enriched_Point_3(double x,double y,double z) : K::Point_3(x,y,z), yupMyPoint(false), mySD(NULL) {}
130 >  FORALLvertices{
131 >    localHullSites++;
132 >    
133 >    int idx = qh_pointid(vertex->point);
134  
135 <  bool isMyPoint() const{ return yupMyPoint; }
114 <  void myPoint(){ yupMyPoint = true; }
115 <  void setSD(StuntDouble* SD){mySD = SD;}
116 <  StuntDouble* getStuntDouble(){return mySD;}
117 < private:
118 <  bool yupMyPoint;
119 <  StuntDouble* mySD;
135 >    indexMap.push_back(idx);
136  
137 < };
137 >    coords.push_back(ptArray[dim_  * idx]);
138 >    coords.push_back(ptArray[dim_  * idx + 1]);
139 >    coords.push_back(ptArray[dim_  * idx + 2]);
140  
141 +    StuntDouble* sd = bodydoubles[idx];
142  
143 +    Vector3d vel = sd->getVel();
144 +    vels.push_back(vel.x());
145 +    vels.push_back(vel.y());
146 +    vels.push_back(vel.z());
147  
148 +    masses.push_back(sd->getMass());
149 +  }
150  
151 +  MPI_Allgather(&localHullSites, 1, MPI_INT, &hullSitesOnProc[0],
152 +                1, MPI_INT, MPI_COMM_WORLD);
153  
154 <    // compare Point_3's... used in setting up the STL map from points to indices
155 < template <typename Pt3>
156 < struct Point_3_comp {
157 <  bool operator() (const Pt3 & p, const Pt3 & q) const {
131 <    return CGAL::lexicographically_xyz_smaller(p,q); // this is defined inline & hence we had to create fn object & not ptrfun
154 >  int globalHullSites = 0;
155 >  for (int iproc = 0; iproc < nproc; iproc++){
156 >    globalHullSites += hullSitesOnProc[iproc];
157 >    coordsOnProc[iproc] = dim_ * hullSitesOnProc[iproc];
158    }
133 };
159  
160 < // coordinate-based hashing inefficient but can we do better if pts are copied?
161 < typedef std::map<Point_3, StuntDouble* ,Point_3_comp<Point_3> > ptMapType;
137 <
138 < #ifdef IS_MPI
139 < struct {
140 <  double x,y,z;
141 < } surfacePt;
142 < #endif
143 <
144 < ConvexHull::ConvexHull() : Hull(){
145 <  //If we are doing the mpi version, set up some vectors for data communication
146 < #ifdef IS_MPI
147 <
148 <
149 < nproc_ = MPI::COMM_WORLD.Get_size();
150 < myrank_ = MPI::COMM_WORLD.Get_rank();
151 < NstoProc_ = new int[nproc_];
152 < vecdispls_   = new int[nproc_];
153 < displs_ = new int[nproc_];
154 < // Create a surface point type in MPI to send
155 < surfacePtType = MPI::DOUBLE.Create_contiguous(3);
156 < surfacePtType.Commit();
157 <
158 <
159 < #endif
160 < }
161 <
162 < void ConvexHull::computeHull(std::vector<StuntDouble*> bodydoubles)
163 < {
164 <
165 <  std::vector<Enriched_Point_3> points;
166 <  ptMapType myMap;
167 <  Point_iterator   hc;
160 >  displacements[0] = 0;
161 >  vectorDisplacements[0] = 0;
162    
163 <  // Copy the positon vector into a points vector for cgal.
164 <  std::vector<StuntDouble*>::iterator SD;
163 >  for (int iproc = 1; iproc < nproc; iproc++){
164 >    displacements[iproc] = displacements[iproc-1] + hullSitesOnProc[iproc-1];
165 >    vectorDisplacements[iproc] = vectorDisplacements[iproc-1] + coordsOnProc[iproc-1];
166 >  }
167  
168 <    for (SD =bodydoubles.begin(); SD != bodydoubles.end(); ++SD)
169 <    {
170 <      Vector3d pos = (*SD)->getPos();
175 <      Enriched_Point_3* pt = new Enriched_Point_3(pos.x(),pos.y(),pos.z());
176 <      pt->setSD(*SD);    
177 <      points.push_back(*pt);
178 <      // myMap[pt]=(*SD);
179 <    }
180 <  
181 <  // define object to hold convex hull
182 <  CGAL::Object ch_object_;
183 <  Polyhedron_3 polyhedron;
168 >  vector<double> globalCoords(dim_ * globalHullSites);
169 >  vector<double> globalVels(dim_ * globalHullSites);
170 >  vector<double> globalMasses(globalHullSites);
171  
172 <  // compute convex hull
172 >  int count = coordsOnProc[myrank];
173    
174 <  std::vector<Enriched_Point_3>::iterator testpt;
174 >  MPI_Allgatherv(&coords[0], count, MPI_DOUBLE, &globalCoords[0],
175 >                 &coordsOnProc[0], &vectorDisplacements[0],
176 >                 MPI_DOUBLE, MPI_COMM_WORLD);
177    
178 +  MPI_Allgatherv(&vels[0], count, MPI_DOUBLE, &globalVels[0],
179 +                 &coordsOnProc[0], &vectorDisplacements[0],
180 +                 MPI_DOUBLE, MPI_COMM_WORLD);
181    
182 <
183 <  CGAL::convex_hull_3(points.begin(), points.end(), polyhedron);
184 <
193 <
194 <
195 <  Ns_ = polyhedron.size_of_vertices();
196 <
197 < #ifdef IS_MPI
198 <  /* Gather an array of the number of verticies on each processor */
182 >  MPI_Allgatherv(&masses[0], localHullSites, MPI_DOUBLE,
183 >                 &globalMasses[0], &hullSitesOnProc[0],
184 >                 &displacements[0], MPI_DOUBLE, MPI_COMM_WORLD);
185    
186 <
187 <  surfacePtsGlobal_.clear();
188 <  surfacePtsLocal_.clear();
189 <
190 <  MPI::COMM_WORLD.Allgather(&Ns_,1,MPI::INT,&NstoProc_[0],1,MPI::INT);
191 <
192 <  for (int i = 0; i < nproc_; i++){
193 <    Nsglobal_ += NstoProc_[i];
186 >  // Free previous hull
187 >  qh_freeqhull(!qh_ALL);
188 >  qh_memfreeshort(&curlong, &totlong);
189 >  if (curlong || totlong) {
190 >    sprintf(painCave.errMsg, "ConvexHull: qhull internal warning:\n"
191 >            "\tdid not free %d bytes of long memory (%d pieces)",
192 >            totlong, curlong);
193 >    painCave.isFatal = 1;
194 >    simError();
195    }
209  /*Reminder ideally, we would like to reserve size for the vectors here*/
210  surfacePtsLocal_.reserve(Ns_);
211  surfacePtsGlobal_.resize(Nsglobal_);
212  //  std::fill(surfacePtsGlobal_.begin(),surfacePtsGlobal_.end(),0);
213
214  /* Build a displacements array */
215  for (int i = 1; i < nproc_; i++){
216    vecdispls_[i] = vecdispls_[i-1] + NstoProc_[i-1];
217  }
196    
197 <  int noffset = vecdispls_[myrank_];
198 <  /* gather the potential hull */
199 <  
200 <  
201 <  for (hc =polyhedron.points_begin();hc != polyhedron.points_end(); ++hc){
202 <    Point_3 mypoint = *hc;
203 <    surfacePt_ mpiSurfacePt;
204 <    mpiSurfacePt.x = CGAL::to_double(mypoint.x());
205 <    mpiSurfacePt.y = CGAL::to_double(mypoint.y());
228 <    mpiSurfacePt.z = CGAL::to_double(mypoint.z());
229 <    surfacePtsLocal_.push_back(mpiSurfacePt);
230 <  }
197 >  if (qh_new_qhull(dim_, globalHullSites, &globalCoords[0], ismalloc,
198 >                   const_cast<char *>(options_.c_str()), NULL, stderr)){
199 >    
200 >    sprintf(painCave.errMsg,
201 >            "ConvexHull: Qhull failed to compute global convex hull");
202 >    painCave.isFatal = 1;
203 >    simError();
204 >    
205 >  } //qh_new_qhull
206  
232  MPI::COMM_WORLD.Allgatherv(&surfacePtsLocal_[0],Ns_,surfacePtType,&surfacePtsGlobal_[0],NstoProc_,vecdispls_,surfacePtType);
233  std::vector<surfacePt_>::iterator spt;
234  std::vector<Enriched_Point_3> gblpoints;
235
236  int mine = 0;
237  int pointidx = 0;
238  for (spt = surfacePtsGlobal_.begin(); spt != surfacePtsGlobal_.end(); ++spt)
239    {    
240      surfacePt_ thispos = *spt;
241      Enriched_Point_3 ept(thispos.x,thispos.y,thispos.z);
242      if (mine >= noffset && mine < noffset + Ns_){
243        ept.myPoint();
244        ept.setSD(points[pointidx].getStuntDouble());
245        pointidx++;
246      }
247      gblpoints.push_back(ept);
248
249      mine++;
250    }
251
252  /* Compute the global hull */
253  polyhedron.clear();
254  CGAL::convex_hull_3(gblpoints.begin(), gblpoints.end(), polyhedron);
255
256
207   #endif
208 <
209 <
208 >  // commented out below, so comment out here also.
209 >  // intPoint = qh interior_point;
210 >  // RealType calcvol = 0.0;
211    
212 <  /* Loop over all of the surface triangles and build data structures for atoms and normals*/
262 <  Facet_iterator j;
263 <  area_ = 0;
264 <  for ( j = polyhedron.facets_begin(); j !=polyhedron.facets_end(); ++j) {
265 <    Halfedge_handle h = j->halfedge();
212 >  qh_triangulate ();
213  
214 <    Point_3 r0=h->vertex()->point();
215 <    Point_3 r1=h->next()->vertex()->point();
216 <    Point_3 r2=h->next()->next()->vertex()->point();
217 <
218 <    Point_3* pr0 = &r0;
219 <    Point_3* pr1 = &r1;
220 <    Point_3* pr2 = &r2;
221 <
222 <    Enriched_Point_3* er0 = static_cast<Enriched_Point_3*>(pr0);
223 <    Enriched_Point_3* er1 = static_cast<Enriched_Point_3*>(pr1);
224 <    Enriched_Point_3* er2 = static_cast<Enriched_Point_3*>(pr2);
225 <
226 <    // StuntDouble* sd = er0->getStuntDouble();
227 <    std::cerr << "sd globalIndex = " << to_double(er0->x()) << "\n";
281 <  
282 <    Point_3 thisCentroid = CGAL::centroid(r0,r1,r2);
283 <
284 <    Vector_3 normal = CGAL::cross_product(r1-r0,r2-r0);
285 <
286 <    Triangle* face = new Triangle();
287 <    Vector3d V3dNormal(CGAL::to_double(normal.x()),CGAL::to_double(normal.y()),CGAL::to_double(normal.z()));
288 <    Vector3d V3dCentroid(CGAL::to_double(thisCentroid.x()),CGAL::to_double(thisCentroid.y()),CGAL::to_double(thisCentroid.z()));
289 <    face->setNormal(V3dNormal);
290 <    face->setCentroid(V3dCentroid);
291 <    RealType faceArea = 0.5*V3dNormal.length();
292 <    face->setArea(faceArea);
293 <    area_ += faceArea;
294 <    Triangles_.push_back(face);
295 <    //    ptMapType::const_iterator locn=myMap.find(mypoint);
296 <    //    int myIndex = locn->second;
297 <
298 <  }
299 <  
300 <  
301 <
302 <
303 < }
304 < void ConvexHull::printHull(const std::string& geomFileName)
305 < {
306 <  /*
307 <  std::ofstream newGeomFile;
308 <  
309 <  //create new .md file based on old .md file
310 <  newGeomFile.open("testhull.off");
311 <  
312 <  // Write polyhedron in Object File Format (OFF).
313 <  CGAL::set_ascii_mode( std::cout);
314 <  newGeomFile << "OFF" << std::endl << polyhedron.size_of_vertices() << ' '
315 <              << polyhedron.size_of_facets() << " 0" << std::endl;
316 <  std::copy( polyhedron.points_begin(), polyhedron.points_end(),
317 <             std::ostream_iterator<Point_3>( newGeomFile, "\n"));
318 <  for (  Facet_iterator i = polyhedron.facets_begin(); i != polyhedron.facets_end(); ++i) {
319 <    Halfedge_facet_circulator j = i->facet_begin();
320 <    // Facets in polyhedral surfaces are at least triangles.
321 <    CGAL_assertion( CGAL::circulator_size(j) >= 3);
322 <    newGeomFile << CGAL::circulator_size(j) << ' ';
323 <    do {
324 <      newGeomFile << ' ' << std::distance(polyhedron.vertices_begin(), j->vertex());
325 <    } while ( ++j != i->facet_begin());
326 <    newGeomFile << std::endl;
327 <  }
328 <  
329 <  newGeomFile.close();
330 <  */
331 < /*
332 <  std::ofstream newGeomFile;
333 <
334 <  //create new .md file based on old .md file
335 <  newGeomFile.open(geomFileName.c_str());
336 <
337 <  // Write polyhedron in Object File Format (OFF).
338 <  CGAL::set_ascii_mode( std::cout);
339 <  newGeomFile << "OFF" << std::endl << ch_polyhedron.size_of_vertices() << ' '
340 <  << ch_polyhedron.size_of_facets() << " 0" << std::endl;
341 <  std::copy( ch_polyhedron.points_begin(), ch_polyhedron.points_end(),
342 <             std::ostream_iterator<Point_3>( newGeomFile, "\n"));
343 <  for (  Facet_iterator i = ch_polyhedron.facets_begin(); i != ch_polyhedron.facets_end(); ++i)
344 <    {
345 <      Halfedge_facet_circulator j = i->facet_begin();
346 <      // Facets in polyhedral surfaces are at least triangles.
347 <      CGAL_assertion( CGAL::circulator_size(j) >= 3);
348 <      newGeomFile << CGAL::circulator_size(j) << ' ';
349 <      do
350 <        {
351 <          newGeomFile << ' ' << std::distance(ch_polyhedron.vertices_begin(), j->vertex());
352 <        }
353 <      while ( ++j != i->facet_begin());
354 <      newGeomFile << std::endl;
355 <    }
356 <
357 <  newGeomFile.close();
358 < */
359 <
360 < }
214 >  FORALLfacets {  
215 >    Triangle face;
216 >    //Qhull sets the unit normal in facet->normal
217 >    Vector3d V3dNormal(facet->normal[0], facet->normal[1], facet->normal[2]);
218 >    face.setUnitNormal(V3dNormal);
219 >    
220 >    RealType faceArea = qh_facetarea(facet);
221 >    face.setArea(faceArea);
222 >    
223 >    vertices = qh_facet3vertex(facet);
224 >      
225 >    coordT *center = qh_getcenter(vertices);
226 >    Vector3d V3dCentroid(center[0], center[1], center[2]);
227 >    face.setCentroid(V3dCentroid);
228  
229 +    Vector3d faceVel = V3Zero;
230 +    Vector3d p[3];
231 +    RealType faceMass = 0.0;
232  
233 +    int ver = 0;
234  
235 +    FOREACHvertex_(vertices){
236 +      int id = qh_pointid(vertex->point);
237 +      p[ver][0] = vertex->point[0];
238 +      p[ver][1] = vertex->point[1];
239 +      p[ver][2] = vertex->point[2];
240 +      Vector3d vel;
241 +      RealType mass;
242  
365
366
367
368 #else
369 #ifdef HAVE_QHULL
370 /* Old options Qt Qu Qg QG0 FA */
371 /* More old opts Qc Qi Pp*/
372 ConvexHull::ConvexHull() : Hull(), dim_(3), options_("qhull Qt Pp"), Ns_(200), nTriangles_(0) {
373  //If we are doing the mpi version, set up some vectors for data communication
243   #ifdef IS_MPI
244 +      vel = Vector3d(globalVels[dim_ * id],
245 +                     globalVels[dim_ * id + 1],
246 +                     globalVels[dim_ * id + 2]);
247 +      mass = globalMasses[id];
248  
249 +      // localID will be between 0 and hullSitesOnProc[myrank] if we
250 +      // own this guy.
251  
252 < nproc_ = MPI::COMM_WORLD.Get_size();
378 < myrank_ = MPI::COMM_WORLD.Get_rank();
379 < NstoProc_ = new int[nproc_];
380 < vecdispls_   = new int[nproc_];
381 < vecNstoProc_ = new int[nproc_];
382 < displs_ = new int[nproc_];
252 >      int localID = id - displacements[myrank];
253  
384 // Create a surface point type in MPI to send
385 //surfacePtType = MPI::DOUBLE.Create_contiguous(3);
386 // surfacePtType.Commit();
387
254  
255 < #endif
256 < }
257 <
258 <
393 <
394 < void ConvexHull::computeHull(std::vector<StuntDouble*> bodydoubles)
395 < {
396 <  
397 <  std::vector<int> surfaceIDs;
398 <  std::vector<int> surfaceIDsGlobal;
399 <  std::vector<int> localPtsMap;
400 <  int numpoints = bodydoubles.size();
401 <
402 <  //coordT* pt_array;
403 <  coordT* surfpt_array;
404 <  vertexT *vertex, **vertexp;
405 <  facetT *facet;
406 <  setT *vertices;
407 <  int curlong,totlong;
408 <  int id;
409 <  
410 <  coordT *point,**pointp;
411 <
412 <
413 <  FILE *outdummy = NULL;
414 <  FILE *errdummy = NULL;
415 <  
416 <  //pt_array = (coordT*) malloc(sizeof(coordT) * (numpoints * dim_));
417 <
418 < //  double* ptArray = new double[numpoints * 3];
419 <  std::vector<double> ptArray(numpoints*3);
420 <  std::vector<bool> isSurfaceID(numpoints);
421 <
422 <  // Copy the positon vector into a points vector for qhull.
423 <  std::vector<StuntDouble*>::iterator SD;
424 <  int i = 0;
425 <  for (SD =bodydoubles.begin(); SD != bodydoubles.end(); ++SD)
426 <    {
427 <      Vector3d pos = (*SD)->getPos();
428 <      
429 <      ptArray[dim_ * i] = pos.x();
430 <      ptArray[dim_ * i + 1] = pos.y();
431 <      ptArray[dim_ * i + 2] = pos.z();
432 <      i++;
433 <    }
434 <  
435 <
436 <  
437 <  
438 <  
439 <  
440 <  boolT ismalloc = False;
441 <  /* Clean up memory from previous convex hull calculations*/
442 <  
443 <  Triangles_.clear();
444 <  surfaceSDs_.clear();
445 <  surfaceSDs_.reserve(Ns_);
446 <
447 <  if (qh_new_qhull(dim_, numpoints, &ptArray[0], ismalloc,
448 <                    const_cast<char *>(options_.c_str()), NULL, stderr)) {
449 <
450 <      sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute convex hull");
451 <      painCave.isFatal = 1;
452 <      simError();
453 <      
454 <  } //qh_new_qhull
455 <
456 <
457 < #ifdef IS_MPI
458 <  std::vector<double> localPts;
459 <  std::vector<double> localVel;
460 <  std::vector<double> localMass;
461 <  int localPtArraySize;
462 <  
463 <
464 <  std::fill(isSurfaceID.begin(),isSurfaceID.end(),false);
465 <
466 <
467 <  FORALLfacets {
468 <    
469 <    if (!facet->simplicial){
470 <      // should never happen with Qt
471 <      sprintf(painCave.errMsg, "ConvexHull: non-simplicaial facet detected");
472 <      painCave.isFatal = 1;
473 <      simError();
474 <    }
475 <    
476 <    
477 <    vertices = qh_facet3vertex(facet);
478 <    FOREACHvertex_(vertices){
479 <      id = qh_pointid(vertex->point);
480 <
481 <      if( !isSurfaceID[id] ){
482 <        isSurfaceID[id] = true;
255 >      if (localID >= 0 && localID < hullSitesOnProc[myrank]){
256 >        face.addVertexSD(bodydoubles[indexMap[localID]]);
257 >      }else{
258 >        face.addVertexSD(NULL);
259        }
260 <    }      
260 > #else
261 >      vel = bodydoubles[id]->getVel();
262 >      mass = bodydoubles[id]->getMass();
263 >      face.addVertexSD(bodydoubles[id]);      
264 > #endif  
265 >      faceVel = faceVel + vel;
266 >      faceMass = faceMass + mass;
267 >      ver++;      
268 >    } //Foreachvertex
269 >
270 >    face.addVertices(p[0], p[1], p[2]);
271 >    face.setFacetMass(faceMass);
272 >    face.setFacetVelocity(faceVel / RealType(3.0));
273 >    /*
274 >    RealType comparea = face.computeArea();
275 >    realT calcarea = qh_facetarea (facet);
276 >    Vector3d V3dCompNorm = -face.computeUnitNormal();
277 >    RealType thisOffset = ((0.0-p[0][0])*V3dCompNorm[0] + (0.0-p[0][1])*V3dCompNorm[1] + (0.0-p[0][2])*V3dCompNorm[2]);
278 >    RealType dist = facet->offset + intPoint[0]*V3dNormal[0] + intPoint[1]*V3dNormal[1] + intPoint[2]*V3dNormal[2];
279 >    cout << "facet offset and computed offset: " << facet->offset << "  " << thisOffset <<  endl;
280 >    calcvol +=  -dist*comparea/qh hull_dim;
281 >    */
282 >    Triangles_.push_back(face);
283      qh_settempfree(&vertices);      
486      
487  } //FORALLfacets
284  
285 <
490 <
491 <
492 <  int idx = 0;
493 <  int nIsIts = 0;
494 <  FORALLvertices {
495 <    idx = qh_pointid(vertex->point);
496 <    localPts.push_back(ptArray[dim_ * idx]);    
497 <    localPts.push_back(ptArray[dim_ * idx + 1]);
498 <    localPts.push_back(ptArray[dim_ * idx + 2]);
499 <
500 <    Vector3d vel = bodydoubles[idx]->getVel();
501 <    localVel.push_back(vel.x());
502 <    localVel.push_back(vel.y());
503 <    localVel.push_back(vel.z());
504 <
505 <
506 <    RealType bdmass = bodydoubles[idx]->getMass();
507 <    localMass.push_back(bdmass);
508 <
509 <    localPtsMap.push_back(idx);
510 <
511 <  }
512 <
513 <
514 <  localPtArraySize = int(localPts.size()/3.0);
515 <
516 <  MPI::COMM_WORLD.Allgather(&localPtArraySize,1,MPI::INT,&NstoProc_[0],1,MPI::INT);
285 >  } //FORALLfacets
286    
287 <  Nsglobal_=0;
288 <  for (int i = 0; i < nproc_; i++){
289 <    Nsglobal_ += NstoProc_[i];
290 <    vecNstoProc_[i] = NstoProc_[i]*3;
522 <  }
523 <  
524 <
525 <  int nglobalPts = Nsglobal_*3;
526 <
527 <
528 <  std::vector<double> globalPts(nglobalPts);
529 <  std::vector<double> globalVel(nglobalPts);
530 <  std::vector<double> globalMass(Nsglobal_);
531 <
532 <
533 <  
534 <  isSurfaceID.resize(nglobalPts);
535 <
536 <
537 <  std::fill(globalPts.begin(),globalPts.end(),0.0);
538 <
539 <  vecdispls_[0] = 0;
540 <  /* Build a displacements array */
541 <  for (int i = 1; i < nproc_; i++){
542 <    vecdispls_[i] = vecdispls_[i-1] + vecNstoProc_[i-1];
543 <  }
544 <  
545 <  displs_[0] = 0;
546 <  for (int i = 1; i < nproc_; i++){
547 <    displs_[i] = displs_[i-1] + NstoProc_[i-1];
548 <  }
549 <  
550 <  int noffset = displs_[myrank_];
551 <  /* gather the potential hull */
552 <  
553 <  MPI::COMM_WORLD.Allgatherv(&localPts[0],localPtArraySize*3,MPI::DOUBLE,&globalPts[0],&vecNstoProc_[0],&vecdispls_[0],MPI::DOUBLE);
554 <  MPI::COMM_WORLD.Allgatherv(&localVel[0],localPtArraySize*3,MPI::DOUBLE,&globalVel[0],&vecNstoProc_[0],&vecdispls_[0],MPI::DOUBLE);
555 <  MPI::COMM_WORLD.Allgatherv(&localMass[0],localPtArraySize,MPI::DOUBLE,&globalMass[0],&NstoProc_[0],&displs_[0],MPI::DOUBLE);
556 <
557 <  /*
558 <  int tmpidx = 0;
559 <  
560 <  if (myrank_ == 0){
561 <    for (i = 0; i < nglobalPts-3; i++){      
562 <      std::cout << "Au   " << globalPts[tmpidx] << "  " << globalPts[tmpidx+1] << "  " << globalPts[tmpidx +2] << std::endl;
563 <      tmpidx = tmpidx + 3;
564 <    }
565 <  }
566 <  */
567 <  
568 <  // Free previous hull
287 >  qh_getarea(qh facet_list);
288 >  volume_ = qh totvol;
289 >  area_ = qh totarea;
290 >    
291    qh_freeqhull(!qh_ALL);
292    qh_memfreeshort(&curlong, &totlong);
293 <  if (curlong || totlong)
294 <    std::cerr << "qhull internal warning (main): did not free %d bytes of long memory (%d pieces) "
295 <              << totlong << curlong << std::endl;
293 >  if (curlong || totlong) {
294 >    sprintf(painCave.errMsg, "ConvexHull: qhull internal warning:\n"
295 >            "\tdid not free %d bytes of long memory (%d pieces)",
296 >            totlong, curlong);
297 >    painCave.isFatal = 1;
298 >    simError();
299 >  }
300 > }
301  
302 <  if (qh_new_qhull(dim_, Nsglobal_, &globalPts[0], ismalloc,
303 <                    const_cast<char *>(options_.c_str()), NULL, stderr)){
577 <
578 <      sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute global convex hull");
579 <      painCave.isFatal = 1;
580 <      simError();
581 <      
582 <  } //qh_new_qhull
583 <
584 < #endif
585 <
586 <
587 <
588 <
589 <
590 <
591 <    unsigned int nf = qh num_facets;
592 <    
593 <    /* Build Surface SD list first */
594 <
595 <    std::fill(isSurfaceID.begin(),isSurfaceID.end(),false);
596 <    int numvers = 0;
597 <    FORALLfacets {
598 <      
599 <      if (!facet->simplicial){
600 <      // should never happen with Qt
601 <        sprintf(painCave.errMsg, "ConvexHull: non-simplicaial facet detected");
602 <        painCave.isFatal = 1;
603 <        simError();
604 <      } //simplicical
605 <      
606 <      Triangle face;
607 <      Vector3d  V3dNormal(facet->normal[0],facet->normal[1],facet->normal[2]);
608 <      face.setNormal(V3dNormal);
609 <
610 <      
611 <
612 <      //RealType faceArea = 0.5*V3dNormal.length();
613 <      RealType faceArea = qh_facetarea(facet);
614 <      face.setArea(faceArea);
615 <
616 <
617 <      vertices = qh_facet3vertex(facet);
618 <      
619 <      coordT *center = qh_getcenter(vertices);
620 <      Vector3d V3dCentroid(center[0], center[1], center[2]);
621 <      face.setCentroid(V3dCentroid);
622 <      Vector3d faceVel = V3Zero;
623 <      Vector3d p[3];
624 <      RealType faceMass = 0.0;
625 <      int ver = 0;
626 <      FOREACHvertex_(vertices){
627 <        id = qh_pointid(vertex->point);
628 <        p[ver][0] = vertex->point[0];
629 <        p[ver][1] = vertex->point[1];
630 <        p[ver][2] = vertex->point[2];
631 <        int localindex = id;
302 > void ConvexHull::printHull(const string& geomFileName) {
303 >  
304   #ifdef IS_MPI
305 <        Vector3d velVector(globalVel[dim_ * id],globalVel[dim_ * id + 1], globalVel[dim_ * id + 2]);
634 <        
635 <        faceVel = faceVel + velVector;
636 <        faceMass = faceMass + globalMass[id];
637 <        if (id >= noffset && id < (noffset + localPtArraySize) ){
638 <          
639 <          localindex = localPtsMap[id-noffset];
640 < #else
641 <          faceVel = faceVel + bodydoubles[localindex]->getVel();
642 <          faceMass = faceMass + bodydoubles[localindex]->getMass();
305 >  if (worldRank == 0)  {
306   #endif
307 <          face.addVertexSD(bodydoubles[localindex]);
645 <          if( !isSurfaceID[id] ){
646 <            isSurfaceID[id] = true;
647 < #ifdef IS_MPI      
648 <            
649 < #endif
650 <            
651 <            surfaceSDs_.push_back(bodydoubles[localindex]);
652 <            //   std::cout <<"This ID is: " << bodydoubles[localindex]->getGlobalIndex() << std::endl;
653 <            
654 <          } //IF isSurfaceID
655 <
656 < #ifdef IS_MPI
657 <        
658 <        }else{
659 <          face.addVertexSD(NULL);
660 <          }
661 < #endif
662 <        numvers++;
663 <        ver++;
664 <      } //Foreachvertex
665 <      /*
666 <      if (!SETempty_(facet->coplanarset)){
667 <        FOREACHpoint_(facet->coplanarset){
668 <          id = qh_pointid(point);
669 <          surfaceSDs_.push_back(bodydoubles[id]);
670 <        }
671 <      }
672 <      */
673 <      face.addVertices(p[0],p[1],p[2]);
674 <      face.setFacetMass(faceMass);
675 <      face.setFacetVelocity(faceVel/3.0);
676 <      Triangles_.push_back(face);
677 <      qh_settempfree(&vertices);      
678 <
679 <    } //FORALLfacets
680 <
681 <    /*    
682 <    std::cout << surfaceSDs_.size() << std::endl;
683 <    for (SD = surfaceSDs_.begin(); SD != surfaceSDs_.end(); ++SD){
684 <      Vector3d thisatom = (*SD)->getPos();
685 <      std::cout << "Au " << thisatom.x() << "  " << thisatom.y() << " " << thisatom.z() << std::endl;
686 <    }
687 <    */
688 <
689 <
690 <    Ns_ = surfaceSDs_.size();
691 <    nTriangles_ = Triangles_.size();
307 >    FILE *newGeomFile;
308      
309 <    qh_getarea(qh facet_list);
310 <    volume_ = qh totvol;
311 <    area_ = qh totarea;
309 >    //create new .md file based on old .md file
310 >    newGeomFile = fopen(geomFileName.c_str(), "w");
311 >    qh_findgood_all(qh facet_list);
312 >    for (int i = 0; i < qh_PRINTEND; i++)
313 >      qh_printfacets(newGeomFile, qh PRINTout[i], qh facet_list, NULL, !qh_ALL);
314      
315 <    
316 <    
317 <    qh_freeqhull(!qh_ALL);
318 <    qh_memfreeshort(&curlong, &totlong);
701 <    if (curlong || totlong)
702 <      std::cerr << "qhull internal warning (main): did not free %d bytes of long memory (%d pieces) "
703 <                << totlong << curlong << std::endl;
704 <    
705 <    
706 <    
315 >    fclose(newGeomFile);
316 > #ifdef IS_MPI
317 >  }
318 > #endif
319   }
708
709
710
711 void ConvexHull::printHull(const std::string& geomFileName)
712 {
713
714  FILE *newGeomFile;
715  
716  //create new .md file based on old .md file
717  newGeomFile = fopen(geomFileName.c_str(), "w");
718  qh_findgood_all(qh facet_list);
719  for (int i = 0; i < qh_PRINTEND; i++)
720    qh_printfacets(newGeomFile, qh PRINTout[i], qh facet_list, NULL, !qh_ALL);
721  
722  fclose(newGeomFile);
723 }
320   #endif //QHULL
725 #endif //CGAL
726
727
728

Comparing trunk/src/math/ConvexHull.cpp (property svn:keywords):
Revision 1371 by chuckv, Mon Oct 19 17:44:18 2009 UTC vs.
Revision 1969 by gezelter, Wed Feb 26 14:14:50 2014 UTC

# Line 0 | Line 1
1 + Author Id Revision Date

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines