--- branches/development/src/flucq/FluctuatingChargePropagator.cpp 2012/07/07 03:59:27 1768 +++ trunk/src/flucq/FluctuatingChargePropagator.cpp 2013/07/31 19:30:46 1920 @@ -35,7 +35,7 @@ * * [1] Meineke, et al., J. Comp. Chem. 26, 252-271 (2005). * [2] Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006). - * [3] Sun, Lin & Gezelter, J. Chem. Phys. 128, 24107 (2008). + * [3] Sun, Lin & Gezelter, J. Chem. Phys. 128, 234107 (2008). * [4] Kuang & Gezelter, J. Chem. Phys. 133, 164101 (2010). * [5] Vardeman, Stocker & Gezelter, J. Chem. Theory Comput. 7, 834 (2011). */ @@ -56,27 +56,34 @@ namespace OpenMD { namespace OpenMD { FluctuatingChargePropagator::FluctuatingChargePropagator(SimInfo* info) : - info_(info), hasFlucQ_(false), forceMan_(NULL) { + info_(info), hasFlucQ_(false), forceMan_(NULL), initialized_(false) { Globals* simParams = info_->getSimParams(); - fqParams_ = simParams->getFluctuatingChargeParameters(); + fqParams_ = simParams->getFluctuatingChargeParameters(); } + FluctuatingChargePropagator::~FluctuatingChargePropagator() { + if (fqConstraints_ != NULL) delete fqConstraints_; + } + void FluctuatingChargePropagator::setForceManager(ForceManager* forceMan) { forceMan_ = forceMan; } void FluctuatingChargePropagator::initialize() { - if (info_->usesFluctuatingCharges()) { if (info_->getNFluctuatingCharges() > 0) { hasFlucQ_ = true; - fqConstraints_ = new FluctuatingChargeConstraints(info_); + fqConstraints_ = new FluctuatingChargeConstraints(info_); + fqConstraints_->setConstrainRegions(fqParams_->getConstrainRegions()); } } + + if (!hasFlucQ_) { + initialized_ = true; + return; + } - if (!hasFlucQ_) return; - SimInfo::MoleculeIterator i; Molecule::FluctuatingChargeIterator j; Molecule* mol; @@ -91,19 +98,25 @@ namespace OpenMD { } } - fqConstraints_ = new FluctuatingChargeConstraints(info_); - FluctuatingChargeObjectiveFunction flucQobjf(info_, forceMan_, fqConstraints_); + FluctuatingChargeObjectiveFunction flucQobjf(info_, forceMan_, + fqConstraints_); + DynamicVector initCoords = flucQobjf.setInitialCoords(); - Problem problem(flucQobjf, *(new NoConstraint()), *(new NoStatus()), initCoords); + Problem problem(flucQobjf, *(new NoConstraint()), *(new NoStatus()), + initCoords); + EndCriteria endCriteria(1000, 100, 1e-5, 1e-5, 1e-5); + OptimizationMethod* minim = OptimizationFactory::getInstance()->createOptimization("SD", info_); - DumpStatusFunction dsf(info_); // we want a dump file written every iteration - + DumpStatusFunction dsf(info_); // we want a dump file written + // every iteration minim->minimize(problem, endCriteria); + initialized_ = true; } void FluctuatingChargePropagator::applyConstraints() { + if (!initialized_) initialize(); if (!hasFlucQ_) return; fqConstraints_->applyConstraints(); }