--- trunk/src/applications/staticProps/GofXyz.cpp 2005/04/15 22:04:00 507 +++ trunk/src/applications/staticProps/GofXyz.cpp 2012/03/15 13:50:52 1693 @@ -6,19 +6,10 @@ * redistribute this software in source and binary code form, provided * that the following conditions are met: * - * 1. Acknowledgement of the program authors must be made in any - * publication of scientific results based in part on use of the - * program. An acceptable form of acknowledgement is citation of - * the article in which the program was described (Matthew - * A. Meineke, Charles F. Vardeman II, Teng Lin, Christopher - * J. Fennell and J. Daniel Gezelter, "OOPSE: An Object-Oriented - * Parallel Simulation Engine for Molecular Dynamics," - * J. Comput. Chem. 26, pp. 252-271 (2005)) - * - * 2. Redistributions of source code must retain the above copyright + * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * - * 3. Redistributions in binary form must reproduce the above copyright + * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the * distribution. @@ -37,6 +28,15 @@ * arising out of the use of or inability to use software, even if the * University of Notre Dame has been advised of the possibility of * such damages. + * + * SUPPORT OPEN SCIENCE! If you use OpenMD or its source code in your + * research, please cite the appropriate papers when you publish your + * work. Good starting points are: + * + * [1] Meineke, et al., J. Comp. Chem. 26, 252-271 (2005). + * [2] Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006). + * [3] Sun, Lin & Gezelter, J. Chem. Phys. 128, 24107 (2008). + * [4] Vardeman & Gezelter, in progress (2009). */ #include @@ -44,9 +44,9 @@ #include "applications/staticProps/GofXyz.hpp" #include "utils/simError.h" #include "primitives/Molecule.hpp" -namespace oopse { +namespace OpenMD { - GofXyz::GofXyz(SimInfo* info, const std::string& filename, const std::string& sele1, const std::string& sele2, const std::string& sele3, double len, int nrbins) + GofXyz::GofXyz(SimInfo* info, const std::string& filename, const std::string& sele1, const std::string& sele2, const std::string& sele3, RealType len, int nrbins) : RadialDistrFunc(info, filename, sele1, sele2), evaluator3_(info), seleMan3_(info), len_(len), halfLen_(len/2), nRBins_(nrbins) { setOutputName(getPrefix(filename) + ".gxyz"); @@ -100,13 +100,14 @@ namespace oopse { StuntDouble* sd3; for (sd1 = seleMan1_.beginSelected(i), sd3 = seleMan3_.beginSelected(j); - sd1 != NULL, sd3 != NULL; + sd1 != NULL || sd3 != NULL; sd1 = seleMan1_.nextSelected(i), sd3 = seleMan3_.nextSelected(j)) { Vector3d r3 =sd3->getPos(); Vector3d r1 = sd1->getPos(); Vector3d v1 = r3 - r1; - info_->getSnapshotManager()->getCurrentSnapshot()->wrapVector(v1); + if (usePeriodicBoundaryConditions_) + info_->getSnapshotManager()->getCurrentSnapshot()->wrapVector(v1); Vector3d zaxis = sd1->getElectroFrame().getColumn(2); Vector3d xaxis = cross(v1, zaxis); Vector3d yaxis = cross(zaxis, xaxis); @@ -130,7 +131,8 @@ namespace oopse { Vector3d pos1 = sd1->getPos(); Vector3d pos2 = sd2->getPos(); Vector3d r12 = pos2 - pos1; - currentSnapshot_->wrapVector(r12); + if (usePeriodicBoundaryConditions_) + currentSnapshot_->wrapVector(r12); std::map::iterator i = rotMats_.find(sd1->getGlobalIndex()); assert(i != rotMats_.end());