--- trunk/src/applications/staticProps/GofXyz.cpp 2012/03/15 13:50:52 1693 +++ trunk/src/applications/staticProps/GofXyz.cpp 2012/08/30 17:18:22 1790 @@ -36,7 +36,8 @@ * [1] Meineke, et al., J. Comp. Chem. 26, 252-271 (2005). * [2] Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006). * [3] Sun, Lin & Gezelter, J. Chem. Phys. 128, 24107 (2008). - * [4] Vardeman & Gezelter, in progress (2009). + * [4] Kuang & Gezelter, J. Chem. Phys. 133, 164101 (2010). + * [5] Vardeman, Stocker & Gezelter, J. Chem. Theory Comput. 7, 834 (2011). */ #include @@ -78,7 +79,7 @@ namespace OpenMD { } - void GofXyz::initalizeHistogram() { + void GofXyz::initializeHistogram() { //calculate the center of mass of the molecule of selected stuntdouble in selection1 if (!evaluator3_.isDynamic()) { @@ -139,9 +140,9 @@ namespace OpenMD { Vector3d newR12 = i->second * r12; // x, y and z's possible values range -halfLen_ to halfLen_ - int xbin = (newR12.x()+ halfLen_) / deltaR_; - int ybin = (newR12.y() + halfLen_) / deltaR_; - int zbin = (newR12.z() + halfLen_) / deltaR_; + int xbin = int((newR12.x() + halfLen_) / deltaR_); + int ybin = int((newR12.y() + halfLen_) / deltaR_); + int zbin = int((newR12.z() + halfLen_) / deltaR_); if (xbin < nRBins_ && xbin >=0 && ybin < nRBins_ && ybin >= 0 && @@ -158,12 +159,11 @@ namespace OpenMD { //rdfStream << "#selection1: (" << selectionScript1_ << ")\t"; //rdfStream << "selection2: (" << selectionScript2_ << ")\n"; //rdfStream << "#nRBins = " << nRBins_ << "\t maxLen = " << len_ << "deltaR = " << deltaR_ <<"\n"; - for (int i = 0; i < histogram_.size(); ++i) { - - for(int j = 0; j < histogram_[i].size(); ++j) { - - for(int k = 0;k < histogram_[i][j].size(); ++k) { - rdfStream.write(reinterpret_cast(&histogram_[i][j][k] ), sizeof(histogram_[i][j][k] )); + for (unsigned int i = 0; i < histogram_.size(); ++i) { + for(unsigned int j = 0; j < histogram_[i].size(); ++j) { + for(unsigned int k = 0;k < histogram_[i][j].size(); ++k) { + rdfStream.write(reinterpret_cast(&histogram_[i][j][k] ), + sizeof(histogram_[i][j][k] )); } } }