ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/OpenMD/trunk/src/applications/staticProps/GofRAngle.cpp
(Generate patch)

Comparing trunk/src/applications/staticProps/GofRAngle.cpp (file contents):
Revision 1390 by gezelter, Wed Nov 25 20:02:06 2009 UTC vs.
Revision 1796 by gezelter, Mon Sep 10 18:38:44 2012 UTC

# Line 36 | Line 36
36   * [1]  Meineke, et al., J. Comp. Chem. 26, 252-271 (2005).            
37   * [2]  Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006).          
38   * [3]  Sun, Lin & Gezelter, J. Chem. Phys. 128, 24107 (2008).          
39 < * [4]  Vardeman & Gezelter, in progress (2009).                        
39 > * [4]  Kuang & Gezelter,  J. Chem. Phys. 133, 164101 (2010).
40 > * [5]  Vardeman, Stocker & Gezelter, J. Chem. Theory Comput. 7, 834 (2011).
41   */
42  
43   #include <algorithm>
# Line 62 | Line 63 | namespace OpenMD {
63  
64  
65    void GofRAngle::preProcess() {
66 <    for (int i = 0; i < avgGofr_.size(); ++i) {
66 >    for (unsigned int i = 0; i < avgGofr_.size(); ++i) {
67        std::fill(avgGofr_[i].begin(), avgGofr_[i].end(), 0);
68      }
69    }
70  
71 <  void GofRAngle::initalizeHistogram() {
71 >  void GofRAngle::initializeHistogram() {
72      npairs_ = 0;
73 <    for (int i = 0; i < histogram_.size(); ++i){
73 >    for (unsigned int i = 0; i < histogram_.size(); ++i){
74        std::fill(histogram_[i].begin(), histogram_[i].end(), 0);
75      }
76    }
# Line 80 | Line 81 | namespace OpenMD {
81      RealType pairDensity = nPairs /volume;
82      RealType pairConstant = ( 4.0 * NumericConstant::PI * pairDensity ) / 3.0;
83  
84 <    for(int i = 0 ; i < histogram_.size(); ++i){
84 >    for(unsigned int i = 0 ; i < histogram_.size(); ++i){
85  
86        RealType rLower = i * deltaR_;
87        RealType rUpper = rLower + deltaR_;
88        RealType volSlice = ( rUpper * rUpper * rUpper ) - ( rLower * rLower * rLower );
89        RealType nIdeal = volSlice * pairConstant;
90  
91 <      for (int j = 0; j < histogram_[i].size(); ++j){
91 >      for (unsigned int j = 0; j < histogram_[i].size(); ++j){
92          avgGofr_[i][j] += histogram_[i][j] / nIdeal;    
93        }
94      }
# Line 106 | Line 107 | namespace OpenMD {
107        currentSnapshot_->wrapVector(r12);
108  
109      RealType distance = r12.length();
110 <    int whichRBin = distance / deltaR_;
110 >    int whichRBin = int(distance / deltaR_);
111  
112      if (distance <= len_) {
113  
114        RealType cosAngle = evaluateAngle(sd1, sd2);
115        RealType halfBin = (nAngleBins_ - 1) * 0.5;
116 <      int whichThetaBin = halfBin * (cosAngle + 1.0);
116 >      int whichThetaBin = int(halfBin * (cosAngle + 1.0));
117        ++histogram_[whichRBin][whichThetaBin];
118          
119        ++npairs_;
# Line 127 | Line 128 | namespace OpenMD {
128        rdfStream << "selection2: (" << selectionScript2_ << ")\n";
129        rdfStream << "#nRBins = " << nRBins_ << "\t maxLen = " << len_ << "deltaR = " << deltaR_ <<"\n";
130        rdfStream << "#nAngleBins =" << nAngleBins_ << "deltaCosAngle = " << deltaCosAngle_ << "\n";
131 <      for (int i = 0; i < avgGofr_.size(); ++i) {
132 <        RealType r = deltaR_ * (i + 0.5);
131 >      for (unsigned int i = 0; i < avgGofr_.size(); ++i) {
132 >        // RealType r = deltaR_ * (i + 0.5);
133  
134 <        for(int j = 0; j < avgGofr_[i].size(); ++j) {
135 <          RealType cosAngle = -1.0 + (j + 0.5)*deltaCosAngle_;
134 >        for(unsigned int j = 0; j < avgGofr_[i].size(); ++j) {
135 >          // RealType cosAngle = -1.0 + (j + 0.5)*deltaCosAngle_;
136            rdfStream << avgGofr_[i][j]/nProcessed_ << "\t";
137          }
138  

Comparing trunk/src/applications/staticProps/GofRAngle.cpp (property svn:keywords):
Revision 1390 by gezelter, Wed Nov 25 20:02:06 2009 UTC vs.
Revision 1796 by gezelter, Mon Sep 10 18:38:44 2012 UTC

# Line 0 | Line 1
1 + Author Id Revision Date

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines