ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/OpenMD/trunk/src/applications/hydrodynamics/ApproximationModel.cpp
(Generate patch)

Comparing trunk/src/applications/hydrodynamics/ApproximationModel.cpp (file contents):
Revision 1208 by xsun, Wed Jan 16 20:19:28 2008 UTC vs.
Revision 1782 by gezelter, Wed Aug 22 02:28:28 2012 UTC

# Line 6 | Line 6
6   * redistribute this software in source and binary code form, provided
7   * that the following conditions are met:
8   *
9 < * 1. Acknowledgement of the program authors must be made in any
10 < *    publication of scientific results based in part on use of the
11 < *    program.  An acceptable form of acknowledgement is citation of
12 < *    the article in which the program was described (Matthew
13 < *    A. Meineke, Charles F. Vardeman II, Teng Lin, Christopher
14 < *    J. Fennell and J. Daniel Gezelter, "OOPSE: An Object-Oriented
15 < *    Parallel Simulation Engine for Molecular Dynamics,"
16 < *    J. Comput. Chem. 26, pp. 252-271 (2005))
17 < *
18 < * 2. Redistributions of source code must retain the above copyright
9 > * 1. Redistributions of source code must retain the above copyright
10   *    notice, this list of conditions and the following disclaimer.
11   *
12 < * 3. Redistributions in binary form must reproduce the above copyright
12 > * 2. Redistributions in binary form must reproduce the above copyright
13   *    notice, this list of conditions and the following disclaimer in the
14   *    documentation and/or other materials provided with the
15   *    distribution.
# Line 37 | Line 28
28   * arising out of the use of or inability to use software, even if the
29   * University of Notre Dame has been advised of the possibility of
30   * such damages.
31 + *
32 + * SUPPORT OPEN SCIENCE!  If you use OpenMD or its source code in your
33 + * research, please cite the appropriate papers when you publish your
34 + * work.  Good starting points are:
35 + *                                                                      
36 + * [1]  Meineke, et al., J. Comp. Chem. 26, 252-271 (2005).            
37 + * [2]  Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006).          
38 + * [3]  Sun, Lin & Gezelter, J. Chem. Phys. 128, 24107 (2008).          
39 + * [4]  Kuang & Gezelter,  J. Chem. Phys. 133, 164101 (2010).
40 + * [5]  Vardeman, Stocker & Gezelter, J. Chem. Theory Comput. 7, 834 (2011).
41   */
42  
43   #include "applications/hydrodynamics/ApproximationModel.hpp"
44   #include "math/LU.hpp"
45   #include "math/DynamicRectMatrix.hpp"
46   #include "math/SquareMatrix3.hpp"
47 < #include "utils/OOPSEConstant.hpp"
47 > #include "utils/PhysicalConstants.hpp"
48   #include "hydrodynamics/Sphere.hpp"
49   #include "hydrodynamics/Ellipsoid.hpp"
50   #include "applications/hydrodynamics/CompositeShape.hpp"
51   #include "math/LU.hpp"
52   #include "utils/simError.h"
53 < namespace oopse {
53 > namespace OpenMD {
54   /**
55   * Reference:
56   * Beatriz Carrasco and Jose Gracia de la Torre, Hydrodynamic Properties of Rigid Particles:
# Line 83 | Line 84 | namespace oopse {
84    
85    bool ApproximationModel::calcHydroPropsAtCR(std::vector<BeadParam>& beads, RealType viscosity, RealType temperature, HydroProp* cr) {
86      
87 <    int nbeads = beads.size();
87 >    unsigned int nbeads = beads.size();
88      DynamicRectMatrix<RealType> B(3*nbeads, 3*nbeads);
89      DynamicRectMatrix<RealType> C(3*nbeads, 3*nbeads);
90      Mat3x3d I;
# Line 120 | Line 121 | namespace oopse {
121      
122      //prepare U Matrix relative to arbitrary origin O(0.0, 0.0, 0.0)
123      std::vector<Mat3x3d> U;
124 <    for (int i = 0; i < nbeads; ++i) {
124 >    for (unsigned int i = 0; i < nbeads; ++i) {
125        Mat3x3d currU;
126        currU.setupSkewMat(beads[i].pos);
127        U.push_back(currU);
# Line 151 | Line 152 | namespace oopse {
152      }
153  
154      // add the volume correction
155 <    Xiorr += (6.0 * viscosity * volume) * I;    
155 >    Xiorr += (RealType(6.0) * viscosity * volume) * I;    
156      
157 <    const RealType convertConstant = 1.439326479e4; //converts Poise angstroms
158 <                                                    // to kcal fs mol^-1 Angstrom^-1
159 <
159 <    Xiott *= convertConstant;
160 <    Xiotr *= convertConstant;
161 <    Xiorr *= convertConstant;
157 >    Xiott *= PhysicalConstants::viscoConvert;
158 >    Xiotr *= PhysicalConstants::viscoConvert;
159 >    Xiorr *= PhysicalConstants::viscoConvert;
160      
161      Mat3x3d tmp;
162      Mat3x3d tmpInv;
# Line 206 | Line 204 | namespace oopse {
204      Dr6x6.getSubMatrix(0, 3, Drrt);
205      Dr6x6.getSubMatrix(3, 0, Drtr);
206      Dr6x6.getSubMatrix(3, 3, Drrr);
207 <    RealType kt = OOPSEConstant::kb * temperature ; // in kcal mol^-1
207 >    RealType kt = PhysicalConstants::kb * temperature ; // in kcal mol^-1
208      Drtt *= kt;
209      Drrt *= kt;
210      Drtr *= kt;
211      Drrr *= kt;
212 <    //Xirtt *= OOPSEConstant::kb * temperature;
213 <    //Xirtr *= OOPSEConstant::kb * temperature;
214 <    //Xirrr *= OOPSEConstant::kb * temperature;
212 >    //Xirtt *= PhysicalConstants::kb * temperature;
213 >    //Xirtr *= PhysicalConstants::kb * temperature;
214 >    //Xirrr *= PhysicalConstants::kb * temperature;
215      
216      Mat6x6d Xi, D;
217  
# Line 259 | Line 257 | namespace oopse {
257    
258    bool ApproximationModel::calcHydroPropsAtCD(std::vector<BeadParam>& beads, RealType viscosity, RealType temperature, HydroProp* cd) {
259      
260 <    int nbeads = beads.size();
260 >    unsigned int nbeads = beads.size();
261      DynamicRectMatrix<RealType> B(3*nbeads, 3*nbeads);
262      DynamicRectMatrix<RealType> C(3*nbeads, 3*nbeads);
263      Mat3x3d I;
# Line 296 | Line 294 | namespace oopse {
294      
295      //prepare U Matrix relative to arbitrary origin O(0.0, 0.0, 0.0)
296      std::vector<Mat3x3d> U;
297 <    for (int i = 0; i < nbeads; ++i) {
297 >    for (unsigned int i = 0; i < nbeads; ++i) {
298        Mat3x3d currU;
299        currU.setupSkewMat(beads[i].pos);
300        U.push_back(currU);
# Line 326 | Line 324 | namespace oopse {
324        }
325      }
326      // add the volume correction here:
327 <    Xirr += (6.0 * viscosity * volume) * I;    
327 >    Xirr += (RealType(6.0) * viscosity * volume) * I;    
328      
329 <    const RealType convertConstant = 1.439326479e4; //converts Poise angstroms
330 <                                                    // to kcal fs mol^-1 Angstrom^-1
331 <    Xitt *= convertConstant;
334 <    Xitr *= convertConstant;
335 <    Xirr *= convertConstant;
329 >    Xitt *= PhysicalConstants::viscoConvert;
330 >    Xitr *= PhysicalConstants::viscoConvert;
331 >    Xirr *= PhysicalConstants::viscoConvert;
332      
333 <    RealType kt = OOPSEConstant::kb * temperature; // in kcal mol^-1
333 >    RealType kt = PhysicalConstants::kb * temperature; // in kcal mol^-1
334      
335      Mat3x3d Dott; //translational diffusion tensor at arbitrary origin O
336      Mat3x3d Dorr; //rotational diffusion tensor at arbitrary origin O
# Line 407 | Line 403 | namespace oopse {
403  
404  
405      //Xidtt in units of kcal*fs*mol^-1*Ang^-2
406 <    //Xid /= OOPSEConstant::energyConvert;
407 <    Xid *= OOPSEConstant::kb * temperature;
406 >    //Xid /= PhysicalConstants::energyConvert;
407 >    Xid *= PhysicalConstants::kb * temperature;
408  
409      Mat6x6d Xi, D;
410  

Comparing trunk/src/applications/hydrodynamics/ApproximationModel.cpp (property svn:keywords):
Revision 1208 by xsun, Wed Jan 16 20:19:28 2008 UTC vs.
Revision 1782 by gezelter, Wed Aug 22 02:28:28 2012 UTC

# Line 0 | Line 1
1 + Author Id Revision Date

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines