--- branches/development/src/nonbonded/EAM.cpp 2011/04/27 18:38:15 1549 +++ branches/development/src/nonbonded/EAM.cpp 2011/06/03 21:39:49 1575 @@ -354,11 +354,12 @@ namespace OpenMD { EAMAtomData data1 = EAMMap[idat.atypes.first]; EAMAtomData data2 = EAMMap[idat.atypes.second]; - if (idat.rij < data1.rcut) - idat.rho_i_at_j = data1.rho->getValueAt(idat.rij); + if ( *(idat.rij) < data1.rcut) + *(idat.rho1) += data1.rho->getValueAt( *(idat.rij)); - if (idat.rij < data2.rcut) - idat.rho_j_at_i = data2.rho->getValueAt(idat.rij); + + if ( *(idat.rij) < data2.rcut) + *(idat.rho2) += data2.rho->getValueAt( *(idat.rij)); return; } @@ -367,12 +368,16 @@ namespace OpenMD { if (!initialized_) initialize(); - EAMAtomData data1 = EAMMap[sdat.atype]; + EAMAtomData data1 = EAMMap[ sdat.atype ]; - pair result = data1.F->getValueAndDerivativeAt(sdat.rho); + pair result = data1.F->getValueAndDerivativeAt( *(sdat.rho) ); - sdat.frho = result.first; - sdat.dfrhodrho = result.second; + *(sdat.frho) = result.first; + *(sdat.dfrhodrho) = result.second; + + sdat.pot[METALLIC_FAMILY] += result.first; + *(sdat.particlePot) += result.first; + return; } @@ -383,7 +388,7 @@ namespace OpenMD { pair res; - if (idat.rij < eamRcut_) { + if ( *(idat.rij) < eamRcut_) { EAMAtomData data1 = EAMMap[idat.atypes.first]; EAMAtomData data2 = EAMMap[idat.atypes.second]; @@ -393,44 +398,43 @@ namespace OpenMD { RealType rci = data1.rcut; RealType rcj = data2.rcut; - RealType rha, drha, rhb, drhb; - RealType pha, dpha, phb, dphb; - RealType phab, dvpdr; + RealType rha(0.0), drha(0.0), rhb(0.0), drhb(0.0); + RealType pha(0.0), dpha(0.0), phb(0.0), dphb(0.0); + RealType phab(0.0), dvpdr(0.0); RealType drhoidr, drhojdr, dudr; - if (idat.rij < rci) { - res = data1.rho->getValueAndDerivativeAt(idat.rij); + if ( *(idat.rij) < rci) { + res = data1.rho->getValueAndDerivativeAt( *(idat.rij)); rha = res.first; drha = res.second; - res = MixingMap[make_pair(idat.atypes.first, idat.atypes.first)].phi->getValueAndDerivativeAt(idat.rij); + res = MixingMap[make_pair(idat.atypes.first, idat.atypes.first)].phi->getValueAndDerivativeAt( *(idat.rij) ); pha = res.first; dpha = res.second; } - if (idat.rij < rcj) { - res = data2.rho->getValueAndDerivativeAt(idat.rij); + if ( *(idat.rij) < rcj) { + res = data2.rho->getValueAndDerivativeAt( *(idat.rij) ); rhb = res.first; drhb = res.second; - res = MixingMap[make_pair(idat.atypes.second, idat.atypes.second)].phi->getValueAndDerivativeAt(idat.rij); + res = MixingMap[make_pair(idat.atypes.second, idat.atypes.second)].phi->getValueAndDerivativeAt( *(idat.rij) ); phb = res.first; dphb = res.second; } - phab = 0.0; - dvpdr = 0.0; - switch(mixMeth_) { case eamJohnson: - if (idat.rij < rci) { + if ( *(idat.rij) < rci) { phab = phab + 0.5 * (rhb / rha) * pha; dvpdr = dvpdr + 0.5*((rhb/rha)*dpha + pha*((drhb/rha) - (rhb*drha/rha/rha))); } + + - if (idat.rij < rcj) { + if ( *(idat.rij) < rcj) { phab = phab + 0.5 * (rha / rhb) * phb; dvpdr = dvpdr + 0.5 * ((rha/rhb)*dphb + phb*((drha/rhb) - (rha*drhb/rhb/rhb))); @@ -439,7 +443,7 @@ namespace OpenMD { break; case eamDaw: - res = MixingMap[idat.atypes].phi->getValueAndDerivativeAt(idat.rij); + res = MixingMap[idat.atypes].phi->getValueAndDerivativeAt( *(idat.rij)); phab = res.first; dvpdr = res.second; @@ -459,28 +463,28 @@ namespace OpenMD { drhoidr = drha; drhojdr = drhb; - dudr = drhojdr*idat.dfrho1 + drhoidr*idat.dfrho2 + dvpdr; + dudr = drhojdr* *(idat.dfrho1) + drhoidr* *(idat.dfrho2) + dvpdr; - idat.f1 = idat.d * dudr / idat.rij; + *(idat.f1) = *(idat.d) * dudr / *(idat.rij); - // particle_pot is the difference between the full potential - // and the full potential without the presence of a particular + // particlePot is the difference between the full potential and + // the full potential without the presence of a particular // particle (atom1). // - // This reduces the density at other particle locations, so - // we need to recompute the density at atom2 assuming atom1 - // didn't contribute. This then requires recomputing the - // density functional for atom2 as well. - // - // Most of the particle_pot heavy lifting comes from the - // pair interaction, and will be handled by vpair. - - idat.fshift1 = data1.F->getValueAt( idat.rho1 - rhb ); - idat.fshift2 = data1.F->getValueAt( idat.rho2 - rha ); + // This reduces the density at other particle locations, so we + // need to recompute the density at atom2 assuming atom1 didn't + // contribute. This then requires recomputing the density + // functional for atom2 as well. - idat.pot[3] += phab; + *(idat.particlePot1) += data2.F->getValueAt( *(idat.rho2) - rha ) + - *(idat.frho2); - idat.vpair += phab; + *(idat.particlePot2) += data1.F->getValueAt( *(idat.rho1) - rhb) + - *(idat.frho1); + + idat.pot[METALLIC_FAMILY] += phab; + + *(idat.vpair) += phab; } return;