ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/OpenMD/branches/development/src/math/ConvexHull.cpp
(Generate patch)

Comparing trunk/src/math/ConvexHull.cpp (file contents):
Revision 1365 by chuckv, Mon Oct 12 20:11:29 2009 UTC vs.
Revision 1377 by gezelter, Wed Oct 21 02:49:43 2009 UTC

# Line 44 | Line 44
44   *
45   *  Created by Charles F. Vardeman II on 11 Dec 2006.
46   *  @author  Charles F. Vardeman II
47 < *  @version $Id: ConvexHull.cpp,v 1.14 2009-10-12 20:11:29 chuckv Exp $
47 > *  @version $Id: ConvexHull.cpp,v 1.18 2009-10-21 02:49:43 gezelter Exp $
48   *
49   */
50  
51   /* Standard includes independent of library */
52 +
53   #include <iostream>
54   #include <fstream>
55   #include <list>
# Line 57 | Line 58
58   #include "math/ConvexHull.hpp"
59   #include "utils/simError.h"
60  
61 + #ifdef IS_MPI
62 + #include <mpi.h>
63 + #endif
64  
65   using namespace oopse;
66  
67 < /* CGAL version of convex hull first then QHULL */
68 < #ifdef HAVE_CGAL
69 < //#include <CGAL/Homogeneous.h>
70 < #include <CGAL/basic.h>
71 < //#include <CGAL/Simple_cartesian.h>
72 < #include <CGAL/Cartesian.h>
73 < #include <CGAL/Origin.h>
74 < #include <CGAL/Exact_predicates_exact_constructions_kernel.h>
75 < #include <CGAL/Convex_hull_traits_3.h>
76 < #include <CGAL/convex_hull_3.h>
77 < #include <CGAL/Polyhedron_traits_with_normals_3.h>
78 < #include <CGAL/Polyhedron_3.h>
75 < #include <CGAL/double.h>
76 < #include <CGAL/number_utils.h>
67 > #ifdef HAVE_QHULL
68 > extern "C"
69 > {
70 > #include <qhull/qhull.h>
71 > #include <qhull/mem.h>
72 > #include <qhull/qset.h>
73 > #include <qhull/geom.h>
74 > #include <qhull/merge.h>
75 > #include <qhull/poly.h>
76 > #include <qhull/io.h>
77 > #include <qhull/stat.h>
78 > }
79  
80 + /* Old options Qt Qu Qg QG0 FA */
81 + /* More old opts Qc Qi Pp*/
82  
83 < //#include <CGAL/Quotient.h>
84 < #include <CGAL/MP_Float.h>
81 < //#include <CGAL/Lazy_exact_nt.h>
83 > ConvexHull::ConvexHull() : Hull(), dim_(3), options_("qhull Qt Pp") {
84 > }
85  
86 <
84 <
85 < typedef CGAL::MP_Float RT;
86 < //typedef double RT;
87 < //typedef CGAL::Homogeneous<RT>                     K;
88 < typedef CGAL::Exact_predicates_exact_constructions_kernel K;
89 < typedef K::Vector_3                               Vector_3;
90 < //typedef CGAL::Convex_hull_traits_3<K>             Traits;
91 < typedef CGAL::Polyhedron_traits_with_normals_3<K> Traits;
92 < //typedef Traits::Polyhedron_3                      Polyhedron_3;
93 < typedef CGAL::Polyhedron_3<Traits>                     Polyhedron_3;
94 < typedef K::Point_3                                Point_3;
95 <
96 <
97 < typedef Polyhedron_3::HalfedgeDS             HalfedgeDS;
98 < typedef Polyhedron_3::Facet_iterator                   Facet_iterator;
99 < typedef Polyhedron_3::Halfedge_around_facet_circulator Halfedge_facet_circulator;
100 < typedef Polyhedron_3::Halfedge_handle Halfedge_handle;
101 < typedef Polyhedron_3::Facet_iterator Facet_iterator;
102 < typedef Polyhedron_3::Plane_iterator Plane_iterator;
103 < typedef Polyhedron_3::Vertex_iterator Vertex_iterator;
104 < typedef Polyhedron_3::Vertex_handle Vertex_handle;
105 < typedef Polyhedron_3::Point_iterator Point_iterator;
86 > void ConvexHull::computeHull(std::vector<StuntDouble*> bodydoubles) {
87  
88 +  int numpoints = bodydoubles.size();
89  
90 +  Triangles_.clear();
91 +  
92 +  vertexT *vertex, **vertexp;
93 +  facetT *facet;
94 +  setT *vertices;
95 +  int curlong, totlong;
96 +  
97 +  std::vector<double> ptArray(numpoints*3);
98 +  std::vector<bool> isSurfaceID(numpoints);
99  
100 < class Enriched_Point_3 : public K::Point_3{
101 < public:
102 <  Enriched_Point_3(double x,double y,double z) : K::Point_3(x,y,z), yupMyPoint(false), mySD(NULL) {}
100 >  // Copy the positon vector into a points vector for qhull.
101 >  std::vector<StuntDouble*>::iterator SD;
102 >  int i = 0;
103 >  for (SD =bodydoubles.begin(); SD != bodydoubles.end(); ++SD){
104 >    Vector3d pos = (*SD)->getPos();      
105 >    ptArray[dim_ * i] = pos.x();
106 >    ptArray[dim_ * i + 1] = pos.y();
107 >    ptArray[dim_ * i + 2] = pos.z();
108 >    i++;
109 >  }
110 >  
111 >  boolT ismalloc = False;
112 >  /* Clean up memory from previous convex hull calculations*/
113 >  
114 >  if (qh_new_qhull(dim_, numpoints, &ptArray[0], ismalloc,
115 >                   const_cast<char *>(options_.c_str()), NULL, stderr)) {
116  
117 <  bool isMyPoint() const{ return yupMyPoint; }
118 <  void myPoint(){ yupMyPoint = true; }
119 <  void setSD(StuntDouble* SD){mySD = SD;}
120 <  StuntDouble* getStuntDouble(){return mySD;}
121 < private:
118 <  bool yupMyPoint;
119 <  StuntDouble* mySD;
117 >    sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute convex hull");
118 >    painCave.isFatal = 1;
119 >    simError();
120 >    
121 >  } //qh_new_qhull
122  
121 };
123  
124 + #ifdef IS_MPI
125 +  //If we are doing the mpi version, set up some vectors for data communication
126 +  
127 +  int nproc = MPI::COMM_WORLD.Get_size();
128 +  int myrank = MPI::COMM_WORLD.Get_rank();
129 +  int localHullSites = 0;
130 +  int* hullSitesOnProc = new int[nproc];
131 +  int* coordsOnProc = new int[nproc];
132 +  int* displacements = new int[nproc];
133 +  int* vectorDisplacements = new int[nproc];
134  
135 +  std::vector<double> coords;
136 +  std::vector<double> vels;
137 +  std::vector<int> objectIDs;
138 +  std::vector<double> masses;
139  
140 +  FORALLvertices{
141 +    localHullSites++;
142 +    
143 +    int idx = qh_pointid(vertex->point);
144 +    coords.push_back(ptArray[dim_  * idx]);
145 +    coords.push_back(ptArray[dim_  * idx + 1]);
146 +    coords.push_back(ptArray[dim_  * idx + 2]);
147  
148 +    StuntDouble* sd = bodydoubles[idx];
149  
150 <    // compare Point_3's... used in setting up the STL map from points to indices
151 < template <typename Pt3>
152 < struct Point_3_comp {
153 <  bool operator() (const Pt3 & p, const Pt3 & q) const {
154 <    return CGAL::lexicographically_xyz_smaller(p,q); // this is defined inline & hence we had to create fn object & not ptrfun
150 >    Vector3d vel = sd->getVel();
151 >    vels.push_back(vel.x());
152 >    vels.push_back(vel.y());
153 >    vels.push_back(vel.z());
154 >
155 >    masses.push_back(sd->getMass());
156    }
133 };
157  
135 // coordinate-based hashing inefficient but can we do better if pts are copied?
136 typedef std::map<Point_3, StuntDouble* ,Point_3_comp<Point_3> > ptMapType;
158  
138 #ifdef IS_MPI
139 struct {
140  double x,y,z;
141 } surfacePt;
142 #endif
159  
160 < ConvexHull::ConvexHull() : Hull(){
161 <  //If we are doing the mpi version, set up some vectors for data communication
146 < #ifdef IS_MPI
160 >  MPI::COMM_WORLD.Allgather(&localHullSites, 1, MPI::INT, &hullSitesOnProc[0],
161 >                            1, MPI::INT);
162  
163 +  int globalHullSites = 0;
164 +  for (int iproc = 0; iproc < nproc; iproc++){
165 +    globalHullSites += hullSitesOnProc[iproc];
166 +    coordsOnProc[iproc] = dim_ * hullSitesOnProc[iproc];
167 +  }
168  
169 < nproc_ = MPI::COMM_WORLD.Get_size();
170 < myrank_ = MPI::COMM_WORLD.Get_rank();
151 < NstoProc_ = new int[nproc_];
152 < vecdispls_   = new int[nproc_];
153 < displs_ = new int[nproc_];
154 < // Create a surface point type in MPI to send
155 < surfacePtType = MPI::DOUBLE.Create_contiguous(3);
156 < surfacePtType.Commit();
157 <
158 <
159 < #endif
160 < }
161 <
162 < void ConvexHull::computeHull(std::vector<StuntDouble*> bodydoubles)
163 < {
164 <
165 <  std::vector<Enriched_Point_3> points;
166 <  ptMapType myMap;
167 <  Point_iterator   hc;
169 >  displacements[0] = 0;
170 >  vectorDisplacements[0] = 0;
171    
172 <  // Copy the positon vector into a points vector for cgal.
173 <  std::vector<StuntDouble*>::iterator SD;
172 >  for (int iproc = 1; iproc < nproc; iproc++){
173 >    displacements[iproc] = displacements[iproc-1] + hullSitesOnProc[iproc-1];
174 >    vectorDisplacements[iproc] = vectorDisplacements[iproc-1] + coordsOnProc[iproc-1];
175 >  }
176  
177 <    for (SD =bodydoubles.begin(); SD != bodydoubles.end(); ++SD)
178 <    {
179 <      Vector3d pos = (*SD)->getPos();
175 <      Enriched_Point_3* pt = new Enriched_Point_3(pos.x(),pos.y(),pos.z());
176 <      pt->setSD(*SD);    
177 <      points.push_back(*pt);
178 <      // myMap[pt]=(*SD);
179 <    }
180 <  
181 <  // define object to hold convex hull
182 <  CGAL::Object ch_object_;
183 <  Polyhedron_3 polyhedron;
177 >  std::vector<double> globalCoords(dim_ * globalHullSites);
178 >  std::vector<double> globalVels(dim_ * globalHullSites);
179 >  std::vector<double> globalMasses(globalHullSites);
180  
181 <  // compute convex hull
181 >  int count = coordsOnProc[myrank];
182    
183 <  std::vector<Enriched_Point_3>::iterator testpt;
184 <  
185 <  
190 <
191 <  CGAL::convex_hull_3(points.begin(), points.end(), polyhedron);
192 <
183 >  MPI::COMM_WORLD.Allgatherv(&coords[0], count, MPI::DOUBLE, &globalCoords[0],
184 >                             &coordsOnProc[0], &vectorDisplacements[0],
185 >                             MPI::DOUBLE);
186  
187 <
188 <  Ns_ = polyhedron.size_of_vertices();
187 >  MPI::COMM_WORLD.Allgatherv(&vels[0], count, MPI::DOUBLE, &globalVels[0],
188 >                             &coordsOnProc[0], &vectorDisplacements[0],
189 >                             MPI::DOUBLE);
190  
191 < #ifdef IS_MPI
192 <  /* Gather an array of the number of verticies on each processor */
193 <  
191 >  MPI::COMM_WORLD.Allgatherv(&masses[0], localHullSites, MPI::DOUBLE,
192 >                             &globalMasses[0], &hullSitesOnProc[0],
193 >                             &displacements[0], MPI::DOUBLE);
194  
195 <  surfacePtsGlobal_.clear();
196 <  surfacePtsLocal_.clear();
197 <
198 <  MPI::COMM_WORLD.Allgather(&Ns_,1,MPI::INT,&NstoProc_[0],1,MPI::INT);
199 <
200 <  for (int i = 0; i < nproc_; i++){
207 <    Nsglobal_ += NstoProc_[i];
208 <  }
209 <  /*Reminder ideally, we would like to reserve size for the vectors here*/
210 <  surfacePtsLocal_.reserve(Ns_);
211 <  surfacePtsGlobal_.resize(Nsglobal_);
212 <  //  std::fill(surfacePtsGlobal_.begin(),surfacePtsGlobal_.end(),0);
213 <
214 <  /* Build a displacements array */
215 <  for (int i = 1; i < nproc_; i++){
216 <    vecdispls_[i] = vecdispls_[i-1] + NstoProc_[i-1];
217 <  }
195 >  // Free previous hull
196 >  qh_freeqhull(!qh_ALL);
197 >  qh_memfreeshort(&curlong, &totlong);
198 >  if (curlong || totlong)
199 >    std::cerr << "qhull internal warning (main): did not free %d bytes of long memory (%d pieces) "
200 >              << totlong << curlong << std::endl;
201    
202 <  int noffset = vecdispls_[myrank_];
203 <  /* gather the potential hull */
204 <  
205 <  
206 <  for (hc =polyhedron.points_begin();hc != polyhedron.points_end(); ++hc){
207 <    Point_3 mypoint = *hc;
208 <    surfacePt_ mpiSurfacePt;
209 <    mpiSurfacePt.x = CGAL::to_double(mypoint.x());
227 <    mpiSurfacePt.y = CGAL::to_double(mypoint.y());
228 <    mpiSurfacePt.z = CGAL::to_double(mypoint.z());
229 <    surfacePtsLocal_.push_back(mpiSurfacePt);
230 <  }
202 >  if (qh_new_qhull(dim_, globalHullSites, &globalCoords[0], ismalloc,
203 >                   const_cast<char *>(options_.c_str()), NULL, stderr)){
204 >    
205 >    sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute global convex hull");
206 >    painCave.isFatal = 1;
207 >    simError();
208 >    
209 >  } //qh_new_qhull
210  
232  MPI::COMM_WORLD.Allgatherv(&surfacePtsLocal_[0],Ns_,surfacePtType,&surfacePtsGlobal_[0],NstoProc_,vecdispls_,surfacePtType);
233  std::vector<surfacePt_>::iterator spt;
234  std::vector<Enriched_Point_3> gblpoints;
235
236  int mine = 0;
237  int pointidx = 0;
238  for (spt = surfacePtsGlobal_.begin(); spt != surfacePtsGlobal_.end(); ++spt)
239    {    
240      surfacePt_ thispos = *spt;
241      Enriched_Point_3 ept(thispos.x,thispos.y,thispos.z);
242      if (mine >= noffset && mine < noffset + Ns_){
243        ept.myPoint();
244        ept.setSD(points[pointidx].getStuntDouble());
245        pointidx++;
246      }
247      gblpoints.push_back(ept);
248
249      mine++;
250    }
251
252  /* Compute the global hull */
253  polyhedron.clear();
254  CGAL::convex_hull_3(gblpoints.begin(), gblpoints.end(), polyhedron);
255
256
211   #endif
212  
213 +  FORALLfacets {  
214 +    Triangle face;
215  
216 <  
217 <  /* Loop over all of the surface triangles and build data structures for atoms and normals*/
218 <  Facet_iterator j;
219 <  area_ = 0;
220 <  for ( j = polyhedron.facets_begin(); j !=polyhedron.facets_end(); ++j) {
221 <    Halfedge_handle h = j->halfedge();
222 <
223 <    Point_3 r0=h->vertex()->point();
224 <    Point_3 r1=h->next()->vertex()->point();
225 <    Point_3 r2=h->next()->next()->vertex()->point();
226 <
271 <    Point_3* pr0 = &r0;
272 <    Point_3* pr1 = &r1;
273 <    Point_3* pr2 = &r2;
274 <
275 <    Enriched_Point_3* er0 = static_cast<Enriched_Point_3*>(pr0);
276 <    Enriched_Point_3* er1 = static_cast<Enriched_Point_3*>(pr1);
277 <    Enriched_Point_3* er2 = static_cast<Enriched_Point_3*>(pr2);
278 <
279 <    // StuntDouble* sd = er0->getStuntDouble();
280 <    std::cerr << "sd globalIndex = " << to_double(er0->x()) << "\n";
281 <  
282 <    Point_3 thisCentroid = CGAL::centroid(r0,r1,r2);
283 <
284 <    Vector_3 normal = CGAL::cross_product(r1-r0,r2-r0);
285 <
286 <    Triangle* face = new Triangle();
287 <    Vector3d V3dNormal(CGAL::to_double(normal.x()),CGAL::to_double(normal.y()),CGAL::to_double(normal.z()));
288 <    Vector3d V3dCentroid(CGAL::to_double(thisCentroid.x()),CGAL::to_double(thisCentroid.y()),CGAL::to_double(thisCentroid.z()));
289 <    face->setNormal(V3dNormal);
290 <    face->setCentroid(V3dCentroid);
291 <    RealType faceArea = 0.5*V3dNormal.length();
292 <    face->setArea(faceArea);
293 <    area_ += faceArea;
294 <    Triangles_.push_back(face);
295 <    //    ptMapType::const_iterator locn=myMap.find(mypoint);
296 <    //    int myIndex = locn->second;
297 <
298 <  }
299 <  
300 <  
301 <
302 <
303 < }
304 < void ConvexHull::printHull(const std::string& geomFileName)
305 < {
306 <  /*
307 <  std::ofstream newGeomFile;
308 <  
309 <  //create new .md file based on old .md file
310 <  newGeomFile.open("testhull.off");
311 <  
312 <  // Write polyhedron in Object File Format (OFF).
313 <  CGAL::set_ascii_mode( std::cout);
314 <  newGeomFile << "OFF" << std::endl << polyhedron.size_of_vertices() << ' '
315 <              << polyhedron.size_of_facets() << " 0" << std::endl;
316 <  std::copy( polyhedron.points_begin(), polyhedron.points_end(),
317 <             std::ostream_iterator<Point_3>( newGeomFile, "\n"));
318 <  for (  Facet_iterator i = polyhedron.facets_begin(); i != polyhedron.facets_end(); ++i) {
319 <    Halfedge_facet_circulator j = i->facet_begin();
320 <    // Facets in polyhedral surfaces are at least triangles.
321 <    CGAL_assertion( CGAL::circulator_size(j) >= 3);
322 <    newGeomFile << CGAL::circulator_size(j) << ' ';
323 <    do {
324 <      newGeomFile << ' ' << std::distance(polyhedron.vertices_begin(), j->vertex());
325 <    } while ( ++j != i->facet_begin());
326 <    newGeomFile << std::endl;
327 <  }
328 <  
329 <  newGeomFile.close();
330 <  */
331 < /*
332 <  std::ofstream newGeomFile;
333 <
334 <  //create new .md file based on old .md file
335 <  newGeomFile.open(geomFileName.c_str());
336 <
337 <  // Write polyhedron in Object File Format (OFF).
338 <  CGAL::set_ascii_mode( std::cout);
339 <  newGeomFile << "OFF" << std::endl << ch_polyhedron.size_of_vertices() << ' '
340 <  << ch_polyhedron.size_of_facets() << " 0" << std::endl;
341 <  std::copy( ch_polyhedron.points_begin(), ch_polyhedron.points_end(),
342 <             std::ostream_iterator<Point_3>( newGeomFile, "\n"));
343 <  for (  Facet_iterator i = ch_polyhedron.facets_begin(); i != ch_polyhedron.facets_end(); ++i)
344 <    {
345 <      Halfedge_facet_circulator j = i->facet_begin();
346 <      // Facets in polyhedral surfaces are at least triangles.
347 <      CGAL_assertion( CGAL::circulator_size(j) >= 3);
348 <      newGeomFile << CGAL::circulator_size(j) << ' ';
349 <      do
350 <        {
351 <          newGeomFile << ' ' << std::distance(ch_polyhedron.vertices_begin(), j->vertex());
352 <        }
353 <      while ( ++j != i->facet_begin());
354 <      newGeomFile << std::endl;
355 <    }
356 <
357 <  newGeomFile.close();
358 < */
359 <
360 < }
361 <
362 <
363 <
364 <
216 >    Vector3d V3dNormal(facet->normal[0], facet->normal[1], facet->normal[2]);
217 >    face.setNormal(V3dNormal);
218 >    
219 >    RealType faceArea = qh_facetarea(facet);
220 >    face.setArea(faceArea);
221 >    
222 >    vertices = qh_facet3vertex(facet);
223 >      
224 >    coordT *center = qh_getcenter(vertices);
225 >    Vector3d V3dCentroid(center[0], center[1], center[2]);
226 >    face.setCentroid(V3dCentroid);
227  
228 +    Vector3d faceVel = V3Zero;
229 +    Vector3d p[3];
230 +    RealType faceMass = 0.0;
231  
232 +    int ver = 0;
233  
234 < #else
235 < #ifdef HAVE_QHULL
236 < /* Old options Qt Qu Qg QG0 FA */
237 < /* More old opts Qc Qi Pp*/
238 < ConvexHull::ConvexHull() : Hull(), dim_(3), options_("qhull Qt Pp"), Ns_(200), nTriangles_(0) {
239 <  //If we are doing the mpi version, set up some vectors for data communication
234 >    FOREACHvertex_(vertices){
235 >      int id = qh_pointid(vertex->point);
236 >      p[ver][0] = vertex->point[0];
237 >      p[ver][1] = vertex->point[1];
238 >      p[ver][2] = vertex->point[2];
239 >      
240 >      Vector3d vel;
241 >      RealType mass;
242 >
243   #ifdef IS_MPI
244 +      vel = Vector3d(globalVels[dim_ * id],
245 +                     globalVels[dim_ * id + 1],
246 +                     globalVels[dim_ * id + 2]);
247 +      mass = globalMasses[id];
248  
249 +      // localID will be between 0 and hullSitesOnProc[myrank] if we
250 +      // own this guy.
251  
252 < nproc_ = MPI::COMM_WORLD.Get_size();
378 < myrank_ = MPI::COMM_WORLD.Get_rank();
379 < NstoProc_ = new int[nproc_];
380 < vecdispls_   = new int[nproc_];
381 < vecNstoProc_ = new int[nproc_];
382 < displs_ = new int[nproc_];
252 >      int localID = id - displacements[myrank];
253  
254 < // Create a surface point type in MPI to send
255 < //surfacePtType = MPI::DOUBLE.Create_contiguous(3);
256 < // surfacePtType.Commit();
257 <
258 <
254 >      if (localID >= 0 && localID < hullSitesOnProc[myrank])
255 >        face.addVertexSD(bodydoubles[localID]);
256 >      
257 > #else
258 >      vel = bodydoubles[id]->getVel();
259 >      mass = bodydoubles[id]->getMass();
260 >      face.addVertexSD(bodydoubles[id]);      
261   #endif
262 < }
262 >        
263 >      faceVel = faceVel + vel;
264 >      faceMass = faceMass + mass;
265 >      ver++;      
266 >    } //Foreachvertex
267  
268 +    face.addVertices(p[0], p[1], p[2]);
269 +    face.setFacetMass(faceMass);
270 +    face.setFacetVelocity(faceVel/3.0);
271 +    Triangles_.push_back(face);
272 +    qh_settempfree(&vertices);      
273  
274 <
394 < void ConvexHull::computeHull(std::vector<StuntDouble*> bodydoubles)
395 < {
274 >  } //FORALLfacets
275    
276 <  std::vector<int> surfaceIDs;
277 <  std::vector<int> surfaceIDsGlobal;
278 <  std::vector<int> localPtsMap;
400 <  int numpoints = bodydoubles.size();
276 >  qh_getarea(qh facet_list);
277 >  volume_ = qh totvol;
278 >  area_ = qh totarea;
279  
402  //coordT* pt_array;
403  coordT* surfpt_array;
404  vertexT *vertex, **vertexp;
405  facetT *facet;
406  setT *vertices;
407  int curlong,totlong;
408  int id;
409  
410  coordT *point,**pointp;
411
412
413  FILE *outdummy = NULL;
414  FILE *errdummy = NULL;
415  
416  //pt_array = (coordT*) malloc(sizeof(coordT) * (numpoints * dim_));
417
418 //  double* ptArray = new double[numpoints * 3];
419  std::vector<double> ptArray(numpoints*3);
420  std::vector<bool> isSurfaceID(numpoints);
421
422  // Copy the positon vector into a points vector for qhull.
423  std::vector<StuntDouble*>::iterator SD;
424  int i = 0;
425  for (SD =bodydoubles.begin(); SD != bodydoubles.end(); ++SD)
426    {
427      Vector3d pos = (*SD)->getPos();
428      
429      ptArray[dim_ * i] = pos.x();
430      ptArray[dim_ * i + 1] = pos.y();
431      ptArray[dim_ * i + 2] = pos.z();
432      i++;
433    }
434  
435
436  
437  
438  
439  
440  boolT ismalloc = False;
441  /* Clean up memory from previous convex hull calculations*/
442  
443  Triangles_.clear();
444  surfaceSDs_.clear();
445  surfaceSDs_.reserve(Ns_);
446
447  if (qh_new_qhull(dim_, numpoints, &ptArray[0], ismalloc,
448                    const_cast<char *>(options_.c_str()), NULL, stderr)) {
449
450      sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute convex hull");
451      painCave.isFatal = 1;
452      simError();
453      
454  } //qh_new_qhull
455
456
280   #ifdef IS_MPI
281 <  std::vector<double> localPts;
282 <  std::vector<double> localVel;
283 <  std::vector<double> localMass;
284 <  int localPtArraySize;
281 >  delete [] hullSitesOnProc;
282 >  delete [] coordsOnProc;
283 >  delete [] displacements;
284 >  delete [] vectorDisplacements;
285 > #endif
286    
463
464  std::fill(isSurfaceID.begin(),isSurfaceID.end(),false);
465
466
467  FORALLfacets {
468    
469    if (!facet->simplicial){
470      // should never happen with Qt
471      sprintf(painCave.errMsg, "ConvexHull: non-simplicaial facet detected");
472      painCave.isFatal = 1;
473      simError();
474    }
475    
476    
477    vertices = qh_facet3vertex(facet);
478    FOREACHvertex_(vertices){
479      id = qh_pointid(vertex->point);
480
481      if( !isSurfaceID[id] ){
482        isSurfaceID[id] = true;
483      }
484    }      
485    qh_settempfree(&vertices);      
486      
487  } //FORALLfacets
488
489
490
491
492  int idx = 0;
493  int nIsIts = 0;
494  FORALLvertices {
495    idx = qh_pointid(vertex->point);
496    localPts.push_back(ptArray[dim_ * idx]);    
497    localPts.push_back(ptArray[dim_ * idx + 1]);
498    localPts.push_back(ptArray[dim_ * idx + 2]);
499
500    Vector3d vel = bodydoubles[idx]->getVel();
501    localVel.push_back(vel.x());
502    localVel.push_back(vel.y());
503    localVel.push_back(vel.z());
504
505
506    RealType bdmass = bodydoubles[idx]->getMass();
507    localMass.push_back(bdmass);
508
509    localPtsMap.push_back(idx);
510
511  }
512
513
514  localPtArraySize = int(localPts.size()/3.0);
515
516  MPI::COMM_WORLD.Allgather(&localPtArraySize,1,MPI::INT,&NstoProc_[0],1,MPI::INT);
517  
518  Nsglobal_=0;
519  for (int i = 0; i < nproc_; i++){
520    Nsglobal_ += NstoProc_[i];
521    vecNstoProc_[i] = NstoProc_[i]*3;
522  }
523  
524
525  int nglobalPts = Nsglobal_*3;
526
527
528  std::vector<double> globalPts(nglobalPts);
529  std::vector<double> globalVel(nglobalPts);
530  std::vector<double> globalMass(Nsglobal_);
531
532
533  
534  isSurfaceID.resize(nglobalPts);
535
536
537  std::fill(globalPts.begin(),globalPts.end(),0.0);
538
539  vecdispls_[0] = 0;
540  /* Build a displacements array */
541  for (int i = 1; i < nproc_; i++){
542    vecdispls_[i] = vecdispls_[i-1] + vecNstoProc_[i-1];
543  }
544  
545  displs_[0] = 0;
546  for (int i = 1; i < nproc_; i++){
547    displs_[i] = displs_[i-1] + NstoProc_[i-1];
548  }
549  
550  int noffset = vecdispls_[myrank_];
551  /* gather the potential hull */
552  
553  MPI::COMM_WORLD.Allgatherv(&localPts[0],localPtArraySize*3,MPI::DOUBLE,&globalPts[0],&vecNstoProc_[0],&vecdispls_[0],MPI::DOUBLE);
554  MPI::COMM_WORLD.Allgatherv(&localVel[0],localPtArraySize*3,MPI::DOUBLE,&globalVel[0],&vecNstoProc_[0],&vecdispls_[0],MPI::DOUBLE);
555  MPI::COMM_WORLD.Allgatherv(&localMass[0],localPtArraySize,MPI::DOUBLE,&globalMass[0],&NstoProc_[0],&displs_[0],MPI::DOUBLE);
556
557  /*
558  int tmpidx = 0;
559  
560  if (myrank_ == 0){
561    for (i = 0; i < nglobalPts-3; i++){      
562      std::cout << "Au   " << globalPts[tmpidx] << "  " << globalPts[tmpidx+1] << "  " << globalPts[tmpidx +2] << std::endl;
563      tmpidx = tmpidx + 3;
564    }
565  }
566  */
567  
568  // Free previous hull
287    qh_freeqhull(!qh_ALL);
288    qh_memfreeshort(&curlong, &totlong);
289    if (curlong || totlong)
290      std::cerr << "qhull internal warning (main): did not free %d bytes of long memory (%d pieces) "
291 <              << totlong << curlong << std::endl;
574 <
575 <  if (qh_new_qhull(dim_, Nsglobal_, &globalPts[0], ismalloc,
576 <                    const_cast<char *>(options_.c_str()), NULL, stderr)){
577 <
578 <      sprintf(painCave.errMsg, "ConvexHull: Qhull failed to compute global convex hull");
579 <      painCave.isFatal = 1;
580 <      simError();
581 <      
582 <  } //qh_new_qhull
583 <
584 < #endif
585 <
586 <
587 <
588 <
589 <
590 <
591 <    unsigned int nf = qh num_facets;
592 <    
593 <    /* Build Surface SD list first */
594 <
595 <    std::fill(isSurfaceID.begin(),isSurfaceID.end(),false);
596 <
597 <    FORALLfacets {
598 <      
599 <      if (!facet->simplicial){
600 <      // should never happen with Qt
601 <        sprintf(painCave.errMsg, "ConvexHull: non-simplicaial facet detected");
602 <        painCave.isFatal = 1;
603 <        simError();
604 <      } //simplicical
605 <      
606 <      Triangle face;
607 <      Vector3d  V3dNormal(facet->normal[0],facet->normal[1],facet->normal[2]);
608 <      face.setNormal(V3dNormal);
609 <
610 <      
611 <
612 <      //RealType faceArea = 0.5*V3dNormal.length();
613 <      RealType faceArea = qh_facetarea(facet);
614 <      face.setArea(faceArea);
615 <
616 <
617 <      vertices = qh_facet3vertex(facet);
618 <      
619 <      coordT *center = qh_getcenter(vertices);
620 <      Vector3d V3dCentroid(center[0], center[1], center[2]);
621 <      face.setCentroid(V3dCentroid);
622 <      Vector3d faceVel = V3Zero;
623 <      Vector3d p[3];
624 <      RealType faceMass = 0.0;
625 <      int ver = 0;
626 <      FOREACHvertex_(vertices){
627 <        id = qh_pointid(vertex->point);
628 <        p[ver][0] = vertex->point[0];
629 <        p[ver][1] = vertex->point[1];
630 <        p[ver][2] = vertex->point[2];
631 <        int localindex = id;
632 < #ifdef IS_MPI
633 <        Vector3d velVector(globalVel[dim_ * id],globalVel[dim_ * id + 1], globalVel[dim_ * id + 1]);
634 <        
635 <        faceVel = faceVel + velVector;
636 <        faceMass = faceMass + globalMass[id];
637 <        if (id >= noffset/3 && id < (noffset + localPtArraySize)/3 ){
638 <          localindex = localPtsMap[id-noffset/3];
639 < #else
640 <          faceVel = faceVel + bodydoubles[localindex]->getVel();
641 <          faceMass = faceMass + bodydoubles[localindex]->getMass();
642 < #endif
643 <          face.addVertexSD(bodydoubles[localindex]);
644 <          if( !isSurfaceID[id] ){
645 <            isSurfaceID[id] = true;
646 < #ifdef IS_MPI      
647 <            
648 < #endif
649 <            
650 <            surfaceSDs_.push_back(bodydoubles[localindex]);
651 <            
652 <          } //IF isSurfaceID
653 <
654 < #ifdef IS_MPI
655 <        
656 <        }else{
657 <          face.addVertexSD(NULL);
658 <          }
659 < #endif
660 <        ver++;
661 <      } //Foreachvertex
662 <      /*
663 <      if (!SETempty_(facet->coplanarset)){
664 <        FOREACHpoint_(facet->coplanarset){
665 <          id = qh_pointid(point);
666 <          surfaceSDs_.push_back(bodydoubles[id]);
667 <        }
668 <      }
669 <      */
670 <      face.addVertices(p[0],p[1],p[2]);
671 <      face.setFacetMass(faceMass);
672 <      face.setFacetVelocity(faceVel/3.0);
673 <      Triangles_.push_back(face);
674 <      qh_settempfree(&vertices);      
675 <
676 <    } //FORALLfacets
677 <
678 <    /*    
679 <    std::cout << surfaceSDs_.size() << std::endl;
680 <    for (SD = surfaceSDs_.begin(); SD != surfaceSDs_.end(); ++SD){
681 <      Vector3d thisatom = (*SD)->getPos();
682 <      std::cout << "Au " << thisatom.x() << "  " << thisatom.y() << " " << thisatom.z() << std::endl;
683 <    }
684 <    */
685 <
686 <
687 <
688 <    Ns_ = surfaceSDs_.size();
689 <    nTriangles_ = Triangles_.size();
690 <    
691 <    qh_getarea(qh facet_list);
692 <    volume_ = qh totvol;
693 <    area_ = qh totarea;
694 <    
695 <    
696 <    
697 <    qh_freeqhull(!qh_ALL);
698 <    qh_memfreeshort(&curlong, &totlong);
699 <    if (curlong || totlong)
700 <      std::cerr << "qhull internal warning (main): did not free %d bytes of long memory (%d pieces) "
701 <                << totlong << curlong << std::endl;
702 <    
703 <    
704 <    
291 >              << totlong << curlong << std::endl;    
292   }
293  
294 <
708 <
709 < void ConvexHull::printHull(const std::string& geomFileName)
710 < {
711 <
294 > void ConvexHull::printHull(const std::string& geomFileName) {
295    FILE *newGeomFile;
296    
297    //create new .md file based on old .md file
# Line 720 | Line 303 | void ConvexHull::printHull(const std::string& geomFile
303    fclose(newGeomFile);
304   }
305   #endif //QHULL
723 #endif //CGAL
724
725
726

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines